Re: [python-committers] Discussions on PRs

2017-02-14 Thread M.-A. Lemburg
On 13.02.2017 23:49, Victor Stinner wrote: > 2017-02-13 19:30 GMT+01:00 Serhiy Storchaka : >> I'm going to >> unsubscribe from getting emails for all pull requests and subscribe to only >> selected ones. > > I did exactly that, very early :-) > > https://github.com/python/cpython/ : "Watch: *not

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Ezio Melotti
On Mon, Feb 13, 2017 at 11:33 AM, M.-A. Lemburg wrote: > With the move to Github, I'm seeing a move away from > discussions on the issue tracker towards discussions on > pull requests. > > Example: https://github.com/python/cpython/pull/4 > > Is this something we should encourage or better ask the

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Victor Stinner
2017-02-13 19:30 GMT+01:00 Serhiy Storchaka : > I'm going to > unsubscribe from getting emails for all pull requests and subscribe to only > selected ones. I did exactly that, very early :-) https://github.com/python/cpython/ : "Watch: *not watching*. Be notified when participating or @mention".

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Serhiy Storchaka
понеділок, 13 лютого 2017 р. 10:33:58 EET M.-A. Lemburg написано: > With the move to Github, I'm seeing a move away from > discussions on the issue tracker towards discussions on > pull requests. > > Example: https://github.com/python/cpython/pull/4 > > Is this something we should encourage or be

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Barry Warsaw
On Feb 13, 2017, at 10:33 AM, M.-A. Lemburg wrote: >Discussion on the PRs would then only be for code review >aspects. +1 On Feb 13, 2017, at 11:49 AM, Stefan Krah wrote: >Realistically, my workload tripled for this one particular issue >compared to our previous workflow. Not to mention the si

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Stefan Krah
On Mon, Feb 13, 2017 at 08:48:08AM -0500, Donald Stufft wrote: > It looks like the person in question is commenting on the issue tracker. Is *now* commenting on the issue tracker as opposed to when I wrote the mail. But hey, it sounds much more impressive the way you phrased it ... Stefan

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Donald Stufft
> On Feb 13, 2017, at 5:49 AM, Stefan Krah wrote: > > What I > see now is that patches without comments emerge really fast: > >https://github.com/python/cpython/pull/65 > It looks like the person in question is commenting on the issue tracker.

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Stefan Krah
On Mon, Feb 13, 2017 at 10:33:58AM +0100, M.-A. Lemburg wrote: > With the move to Github, I'm seeing a move away from > discussions on the issue tracker towards discussions on > pull requests. > > Example: https://github.com/python/cpython/pull/4 > > Is this something we should encourage or bett

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Victor Stinner
I prefer to discuss on the review rather than on the bug tracker. In the extreme case, if we had to choose, I had rather prefer to drop the bug tracker. It is not going to appear since people still have to report bugs without patch :-) Victor 2017-02-13 10:33 GMT+01:00 M.-A. Lemburg : > With the

[python-committers] Discussions on PRs

2017-02-13 Thread M.-A. Lemburg
With the move to Github, I'm seeing a move away from discussions on the issue tracker towards discussions on pull requests. Example: https://github.com/python/cpython/pull/4 Is this something we should encourage or better ask the OPs to open a ticket on the tracker first and reference the PR ther