The PR will not get closed. The message was inaccurate, I have just merged the fix 4 minutes ago. https://github.com/python/cpython/pull/23791
On Tue, Dec 15, 2020 at 6:39 PM Terry Reedy <tjre...@udel.edu> wrote: > As a result of this merge, I have so far received 3 emails with this > scary message. "This PR is stale because it has been open for 30 days > with no activity. Remove stale label or comment or this will be closed > in 5 days". > > https://github.com/python/cpython/pull/23100#issuecomment-745680212 > https://github.com/python/cpython/pull/23098#issuecomment-745680248 > https://github.com/python/cpython/pull/22954#issuecomment-745680870 > > Issues with the change: > > 1. What use is the message and label? In > https://github.com/python/core-workflow/issues/93 > Brett said that 'stale' meant that the PR was waiting on the contributor > -- no CLA or no requested revision. The purpose would then be to prompt > contributors and let committers know that they could not proceed (unless > the block was revision and one was willing to do it oneself). > > The actual change appears to be strictly time based as none of the PRs > above are waiting on the author. So what *is* the purpose of actual > change? > > 2. What is the appropriate waiting time? As I remember, most people in > the discussion I participated in suggested longer than a month, such as > 6 months or a year. We seem to have been ignored. In any case, the > proper answer depends on the purpose. > > One good result was triggering miss-islington to merge a stalled > backport PR with an approval and passed CI tests. > https://github.com/python/cpython/pull/22843#issuecomment-745681140 > For checking miss-islinton backport PRs, I think flagging anythhing over > 7 days would be about right. > > 3. Should 'stale' PRs be auto-closed? Since closing without merging > amounts to rejection, I am strongly opposed. Someone recently merged a > PR based on 2012 patches on bpo. Faster response to contributors would > be great, but using mindless automated rules will not get us there. In > any case, auto-closing after 35 days strikes me as madness. > > As it turns out, Mariatta changed the original 5 days in the PR to -1, > meaning never, but forgot to change the message. > > > -------- Forwarded Message -------- > Subject: [Python-checkins] Adding "stale" GitHub Action (GH-21247) > Date: Tue, 15 Dec 2020 14:59:00 -0500 (EST) > From: Mariatta <webhook-mai...@python.org> > Reply-To: python-...@python.org > To: python-check...@python.org > > > https://github.com/python/cpython/commit/9cc8fa6ac89e9ea3ee483675b3c373650fc1bb3a > commit: 9cc8fa6ac89e9ea3ee483675b3c373650fc1bb3a > branch: master > author: Mariatta <maria...@users.noreply.github.com> > committer: Mariatta <maria...@users.noreply.github.com> > date: 2020-12-15T11:58:43-08:00 > summary: > > Adding "stale" GitHub Action (GH-21247) > > Added the "stale" GitHub action to the CPython repo. > PR's older than 30 days will be labeled as stale using the "stale-pr" > label. > > Closes https://github.com/python/core-workflow/issues/372 > > Co-authored-by: Brett Cannon <br...@python.org> > > files: > A .github/workflows/stale.yml > > diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml > new file mode 100644 > index 0000000000000..706d8e11a2073 > --- /dev/null > +++ b/.github/workflows/stale.yml > @@ -0,0 +1,19 @@ > +name: Mark stale pull requests > + > +on: > + schedule: > + - cron: "0 0 * * *" > + > +jobs: > + stale: > + > + runs-on: ubuntu-latest > + > + steps: > + - uses: actions/stale@v3 > + with: > + repo-token: ${{ secrets.GITHUB_TOKEN }} > + stale-pr-message: 'This PR is stale because it has been open > for 30 days with no activity. Remove stale label or comment or this will > be closed in 5 days' > + stale-pr-label: 'stale' > + days-before-stale: 30 > + days-before-close: -1 > _______________________________________________ > python-committers mailing list -- python-committers@python.org > To unsubscribe send an email to python-committers-le...@python.org > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/python-committers@python.org/message/W5Q3C6PVFXWUIK3A6YFZYTPAYDQYNAOH/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ >
_______________________________________________ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/LT4BFMNBXQ3R36QZ2HCCAXIJN6RRYHNO/ Code of Conduct: https://www.python.org/psf/codeofconduct/
