Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Zachary Ware
On Mon, Jul 24, 2017 at 3:55 AM, Victor Stinner wrote: > Zachary Ware explained me once that "make regen-all" should be run > after "make", but I don't recall why :-) The real kicker is `make clinic`, which fails unless done after `make all`. I'd be all in favor of

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Victor Stinner
Technically, "make regen-all" doesn't use the freshly built Python. It uses PYTHON_FOR_REGEN which is usually "python3". Victor 2017-07-24 15:48 GMT+02:00 Nick Coghlan : > On 24 July 2017 at 18:55, Victor Stinner wrote: >> 2017-07-24 9:37 GMT+02:00

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Nick Coghlan
On 24 July 2017 at 18:55, Victor Stinner wrote: > 2017-07-24 9:37 GMT+02:00 Serhiy Storchaka : >> `make regen-all` touches header files which are dependencies for all >> binaries. I suggest to run `make regen-all` before `make`. > > Zachary Ware

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Victor Stinner
I read again the read and I misunderstood it. I didn't notice that "make buildbottest" recompiles Python. Ok, I confirm the bug. I see two options: * move the "make regen-all" check *before* "make" * move the "make regen-all" check in a different Travis CI. If we move the test in a GCC job, it

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Antoine Pitrou
Le 24/07/2017 à 10:55, Victor Stinner a écrit : > IMHO everything is fine and we don't have to do anything ;-) What do you mean? The fact that all the CPython source code (including C extensions) is compiled twice looks suboptimal to me. We could probably win a minute or two on Travis-CI build

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Serhiy Storchaka
23.07.17 19:04, Brett Cannon пише: If you look at the exact commands it's configure, make, and then make regen-all clinic. My guess is that last command is touching files in such a way that the make bulidbottest is causing make to rebuild some files. `make regen-all` touches header files

Re: [python-committers] Travis-CI compiles twice

2017-07-23 Thread Brett Cannon
If you look at the exact commands it's configure, make, and then make regen-all clinic. My guess is that last command is touching files in such a way that the make bulidbottest is causing make to rebuild some files. On Sun, Jul 23, 2017, 02:39 Antoine Pitrou, wrote: > > Hi,

[python-committers] Travis-CI compiles twice

2017-07-23 Thread Antoine Pitrou
Hi, I've noticed that Travis-CI (sometimes?) compiles CPython twice. Example in https://travis-ci.org/python/cpython/jobs/256552880 First compilation in the "./configure && make" step: https://travis-ci.org/python/cpython/jobs/256552880#L1103 Second compilation in "make buildbottest" step: