Re: [python-committers] Wanting to merge my first PR under github - a bit of advice

2018-03-21 Thread Paul Moore
On 21 March 2018 at 14:02, Mariatta Wijaya wrote: > Some steps were written here: > https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pull-request > > And the section right after explains the backport. Thanks Mariatta - that's exactly what I was looking

Re: [python-committers] Wanting to merge my first PR under github - a bit of advice

2018-03-21 Thread Mariatta Wijaya
Some steps were written here: https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pull-request And the section right after explains the backport. I guess it needs reorganizing. Top posted from my phone while literally on a beach. On Wed, Mar 21, 2018, 7:57 AM Paul Moore

Re: [python-committers] Wanting to merge my first PR under github - a bit of advice

2018-03-21 Thread Paul Moore
On 21 March 2018 at 12:42, Nick Coghlan wrote: > On 21 March 2018 at 06:58, Paul Moore wrote: >> >> Hi, >> Cheryl Sabella kindly migrated a patch I'd put on bpo some time ago >> but forgotten about onto github. The PR (#6158) is ready to go (I >> think)

Re: [python-committers] Wanting to merge my first PR under github - a bit of advice

2018-03-21 Thread Nick Coghlan
On 21 March 2018 at 06:58, Paul Moore wrote: > Hi, > Cheryl Sabella kindly migrated a patch I'd put on bpo some time ago > but forgotten about onto github. The PR (#6158) is ready to go (I > think) but this is the first time since the migration to github that > I've done a

Re: [python-committers] Wanting to merge my first PR under github - a bit of advice

2018-03-20 Thread Brett Cannon
On Tue, 20 Mar 2018 at 13:58 Paul Moore wrote: > Hi, > Cheryl Sabella kindly migrated a patch I'd put on bpo some time ago > but forgotten about onto github. The PR (#6158) is ready to go (I > think) but this is the first time since the migration to github that > I've done a

Re: [python-committers] Wanting to merge my first PR under github - a bit of advice

2018-03-20 Thread Ivan Levkivskyi
Also don't forget to replace # with GH- in the commit message. I was hit by this few times. -- Ivan On 20 March 2018 at 20:58, Paul Moore wrote: > Hi, > Cheryl Sabella kindly migrated a patch I'd put on bpo some time ago > but forgotten about onto github. The PR

[python-committers] Wanting to merge my first PR under github - a bit of advice

2018-03-20 Thread Paul Moore
Hi, Cheryl Sabella kindly migrated a patch I'd put on bpo some time ago but forgotten about onto github. The PR (#6158) is ready to go (I think) but this is the first time since the migration to github that I've done a merge, and I'm not quite sure what the workflow is :-( I didn't see much in the