Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-08 Thread Ivan Levkivskyi
Thank you, Victor! -- Ivan On 8 December 2017 at 16:47, Victor Stinner wrote: > 2017-12-06 17:57 GMT+01:00 Mariatta Wijaya : > > Please add Ivan to the Developer Log in Dev Guide, and he should > subscribe > > to python-committers mailing list :) > > I added Ivan to the Devguide: > https://gi

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-08 Thread Victor Stinner
2017-12-06 17:57 GMT+01:00 Mariatta Wijaya : > Please add Ivan to the Developer Log in Dev Guide, and he should subscribe > to python-committers mailing list :) I added Ivan to the Devguide: https://github.com/python/devguide/commit/f414589365e8d3808eaef3cf9f2b7370314133a1 Victor

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Zachary Ware
On Wed, Dec 6, 2017 at 2:27 PM, Ivan Levkivskyi wrote: > Thank you Mariatta, Ethan, Eric, Guido, and everyone! > I am overwhelmed by all the positive comments! > > I am so glad to be the part of the team and looking forward to make more > contributions. > (Will start right now form polishing PEP 5

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Ivan Levkivskyi
Thank you Mariatta, Ethan, Eric, Guido, and everyone! I am overwhelmed by all the positive comments! I am so glad to be the part of the team and looking forward to make more contributions. (Will start right now form polishing PEP 560 and PEP 562 implementation :-) -- Ivan On 6 December 2017 at

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Ethan Furman
Ivan, Welcome! Glad to have you! -- ~Ethan~ ___ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Mariatta Wijaya
Welcome to the team, Ivan! Mariatta Wijaya ___ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Brett Cannon
I just approve Ivan's subscription request to this list. And I know it's late, but a resounding +1 to this happening! On Wed, 6 Dec 2017 at 09:21 R. David Murray wrote: > On Wed, 06 Dec 2017 08:43:56 -0800, Guido van Rossum > wrote: > > I think I figured it out -- I invited him to the python o

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread R. David Murray
On Wed, 06 Dec 2017 08:43:56 -0800, Guido van Rossum wrote: > I think I figured it out -- I invited him to the python org on GitHub. > Anything else? He needs to subscribe to this mailing list, and the developers.rst in the devguide repo should get an update. That's all I can think of, since ssh

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Ned Deily
On Dec 6, 2017, at 11:57, Mariatta Wijaya wrote: > On Dec 6, 2017 8:44 AM, "Guido van Rossum" wrote: >> I think I figured it out -- I invited him to the python org on GitHub. >> Anything else? > Please add Ivan to the Developer Log in Dev Guide, and he should subscribe to > python-committers ma

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Mariatta Wijaya
Please add Ivan to the Developer Log in Dev Guide, and he should subscribe to python-committers mailing list :) On Dec 6, 2017 8:44 AM, "Guido van Rossum" wrote: I think I figured it out -- I invited him to the python org on GitHub. Anything else? __

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Alex Gaynor
Someone needs to invite him to this list :-) On Dec 6, 2017 11:44 AM, "Guido van Rossum" wrote: > I think I figured it out -- I invited him to the python org on GitHub. > Anything else? > > On Wed, Dec 6, 2017 at 8:37 AM, Guido van Rossum wrote: > >> OK, let's make it so. It's been a long time

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Guido van Rossum
I think I figured it out -- I invited him to the python org on GitHub. Anything else? On Wed, Dec 6, 2017 at 8:37 AM, Guido van Rossum wrote: > OK, let's make it so. It's been a long time since I initiated a new > committer -- what has to happen next? I just flipped his committer bit on > bpo, i

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Guido van Rossum
OK, let's make it so. It's been a long time since I initiated a new committer -- what has to happen next? I just flipped his committer bit on bpo, is there anything else that needs to happen? On Wed, Dec 6, 2017 at 8:27 AM, Yury Selivanov wrote: > +1 from me. I first had an idea to give Ivan co

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Yury Selivanov
+1 from me. I first had an idea to give Ivan commit privileges when I was merging his PEP 526 implementation, so I think it's long overdue. Yury On Tue, Dec 5, 2017 at 8:00 PM, Guido van Rossum wrote: > I'd like to propose Ivan Levkivskyi as a new core committer. He's > (re-)written most of the

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Carol Willing
+1 for nice work on the PEPs > On Dec 6, 2017, at 4:26 AM, Andrew Svetlov wrote: > > +1 > > On Wed, Dec 6, 2017 at 5:47 AM Nick Coghlan > wrote: > On 6 December 2017 at 11:00, Guido van Rossum > wrote: > > I'd like to propose Ivan Levkivskyi

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-06 Thread Andrew Svetlov
+1 On Wed, Dec 6, 2017 at 5:47 AM Nick Coghlan wrote: > On 6 December 2017 at 11:00, Guido van Rossum wrote: > > I'd like to propose Ivan Levkivskyi as a new core committer. He's > > (re-)written most of the typing.py module and will do so again for Python > > 3.7, he's the sole or primary auth

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-05 Thread Nick Coghlan
On 6 December 2017 at 11:00, Guido van Rossum wrote: > I'd like to propose Ivan Levkivskyi as a new core committer. He's > (re-)written most of the typing.py module and will do so again for Python > 3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562), > is co-author on severa

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-05 Thread Terry Reedy
On 12/5/2017 8:00 PM, Guido van Rossum wrote: I'd like to propose Ivan Levkivskyi as a new core committer. He's (re-)written most of the typing.py module and will do so again for Python 3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562), is co-author on several more (483,

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-05 Thread Ethan Furman
On 12/05/2017 05:00 PM, Guido van Rossum wrote: I'd like to propose Ivan Levkivskyi as a new core committer. I thought he already was one. +1 to bring him in! -- ~Ethan~ ___ python-committers mailing list python-committers@python.org https://mail.

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-05 Thread Guido van Rossum
Well he also wrote and implemented PEP 562 (overriding __getattr__ and __dir__ on modules). I'd be happy to tell him to gain other developers' trust before barging into other areas. But isn't that how all core devs work by default? On Tue, Dec 5, 2017 at 5:07 PM, Victor Stinner wrote: > Hi Guido

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-05 Thread Eric V. Smith
+1, without reservation. He was an immense help to me on PEP 557. -- Eric. > On Dec 5, 2017, at 8:00 PM, Guido van Rossum wrote: > > I'd like to propose Ivan Levkivskyi as a new core committer. He's > (re-)written most of the typing.py module and will do so again for Python > 3.7, he's the s

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-05 Thread Victor Stinner
Hi Guido, Since the typing module is out of my interest area, I didn't notice Ivan contributions, so it's hard for me to give an opinion. Should I understand that he will mostly contribute to the typing module? If (in the beginning?) we restrict him to the typing module, I will simply rely on you