+1 thanks for mentoring.
On Mon, Nov 21, 2016, 2:14 PM Victor Stinner
wrote:
> Hi,
>
> 2016-11-21 21:53 GMT+01:00 Brett Cannon :
> > We received an email from Xiang with his SSH keys and GitHub username
> > (although no subscription request for python-committers). Was he finally
> > approved for
Hi,
2016-11-21 21:53 GMT+01:00 Brett Cannon :
> We received an email from Xiang with his SSH keys and GitHub username
> (although no subscription request for python-committers). Was he finally
> approved for receiving commit privileges?
(Oh, I forgot to send an email to python-committers.)
Berke
We received an email from Xiang with his SSH keys and GitHub username
(although no subscription request for python-committers). Was he finally
approved for receiving commit privileges?
On Mon, 14 Nov 2016 at 04:10 Victor Stinner
wrote:
> Hi,
>
> Last months, I noticed that Xiang Zhang is very ac
On 19 November 2016 at 13:07, Berker Peksağ wrote:
> I agree that we should look for people who wrote high quality patches,
> but I think we also should look for people who help other members of
> the community by doing *boring* tasks (e.g. review patches submitted
> by other contributors, triage
On Tue, Nov 15, 2016 at 11:17 AM, Victor Stinner
wrote:
> Hi,
>
> 2016-11-15 1:10 GMT+01:00 Berker Peksağ :
>> Xiang tends to fix things that are not broken,
>
> This sentence sounds strange. What do you mean? :-)
>
>> (...) and when you point out that the thing they are
>> trying to fix is not b
2016-11-18 18:16 GMT+02:00 Victor Stinner :
> Berker, Serhiy: Do you prefer that I mentor Xiang first during one
> month, then give him the commit bit, but continue to mentor him? Or
> are you ok to give him the commit bit right now, and as I wrote,
> request him to ask me before pushing anything?
2016-11-15 19:32 GMT+01:00 :
> Since the first commit 8 months ago I counted about 50 Xiang's committed
> patches, and most of them were committed by me (other 10 core developers
> committed form 1 to 4 Xiang's patches). He helped with reviewing patches and
> discussing issues. His C skills was g
2016-11-15 16:46 GMT+01:00 Senthil Kumaran :
>> Maybe Xiang needs a longer mentoring period than 1 month, but I want
>> to keep him motivated. Active contributors (even inside core
>> developers) are rare, so we always need fresh blood :-)
>
> I agree with this statement. I did a review of his cont
понеділок, 14 листопада 2016 р. 13:09:35 EET Victor Stinner написано:
> Last months, I noticed that Xiang Zhang is very active on the bug
> tracker and propose many enhancements and bug fixes. He contributes to
> Python code, but also to the C code (a rare skill nowadays). Slowly,
> he understood h
On Tue, Nov 15, 2016 at 12:26 AM, Victor Stinner
wrote:
> Maybe Xiang needs a longer mentoring period than 1 month, but I want
> to keep him motivated. Active contributors (even inside core
> developers) are rare, so we always need fresh blood :-)
>
I agree with this statement. I did a review of
Hi,
2016-11-14 23:38 GMT+01:00 Brett Cannon :
> I thought someone asked Xiang if he wanted to be a core dev during the core
> sprints in September and he turned down the offer?
I asked Xiang once on IRC if he would be interested to become a core,
and yes, he is interested.
During the sprint, we
Hi,
2016-11-15 1:10 GMT+01:00 Berker Peksağ :
> Xiang tends to fix things that are not broken,
This sentence sounds strange. What do you mean? :-)
> (...) and when you point out that the thing they are
> trying to fix is not broken, they try to start an endless discussion.
> I also saw a couple
On Mon, Nov 14, 2016 at 3:09 PM, Victor Stinner
wrote:
> Hi,
>
> Last months, I noticed that Xiang Zhang is very active on the bug
> tracker and propose many enhancements and bug fixes. He contributes to
> Python code, but also to the C code (a rare skill nowadays). Slowly,
> he understood how to
I thought someone asked Xiang if he wanted to be a core dev during the core
sprints in September and he turned down the offer?
On Mon, 14 Nov 2016 at 04:10 Victor Stinner
wrote:
> Hi,
>
> Last months, I noticed that Xiang Zhang is very active on the bug
> tracker and propose many enhancements an
On 14 November 2016 at 22:09, Victor Stinner wrote:
> Hi,
>
> Last months, I noticed that Xiang Zhang is very active on the bug
> tracker and propose many enhancements and bug fixes. He contributes to
> Python code, but also to the C code (a rare skill nowadays). Slowly,
> he understood how to pro
+1, if I can vote.
He helped me a lot by reviewing my patch, and fixing issues relating to dict.
Regards,
--
INADA Naoki
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code o
16 matches
Mail list logo
