[python-committers] Recent changes on the CI jobs run on pull requests

2020-05-15 Thread Victor Stinner
Hi,

Changes on CIs run on GitHub pull requests:

* Travis CI became mandatory
* Azure Pipelines is no longer mandatory
* Please watch Windows x64 job: I would like to make it mandatory in 2 weeks

--

I asked to make Azure Pipelines CI not mandatory on Python PRs since
there were more and more random failures and no one was available to
investigate. Also, sadly, currently Azure Pipelines has no way to only
re-trigger a single failed job, but requires to close/re-open a PR to
schedule all jobs. Sadly, some Python tests fail randomly and so
sometimes another CI fails. Also, for backport PRs, closing a PR
triggers miss-inlington which removes the branch which prevents to
re-open the PR. A new backport PR must be created which is not
convenient.

Until Azure Pipelines issues are fixed, I asked Mariatta to make
Travis CI mandatory. In fact, I expected Travis CI to be mandatory, I
never noticed that it was optional. I didn't know that only Azure
Pipelines was mandatory!

--

I also asked Mariatta to make the GitHub Action ("GHA") Windows x64
job mandatory. GHA workflow jobs are skipped for "documentation only"
changes, to not waste CI resources. GHA configuration used
"paths-ignored". Sadly (again!?), if a job using "paths-ignored" is
mandatory, a PR cannot be merged because the mandatory job is skipped
and will never be run... Sadly, it even seems to be a known GitHub
issue which is not going to be fixed soon!

I removed "paths-ignored" to always run jobs, to be able to make a job
mandatory. Then Filipe Laíns found a way to add a new quick (around 15
seconds!) job just for check if a change is documentation only: the
job result is then used to decide if build jobs must be skipped.

In short, the behavior is the same than previously: GHA build jobs are
skipped on documentation only changes. The main difference is that it
became possible to make a GHA job mandatory.

I backported the GHA workflow configuration to Python 3.8 and 3.7.
Mariatta suggested to watch the Windows x64 job for 2 weeks to check
if it's stable before making it mandatory.

Hopefully, in my experience, the Windows x64 job is (very) reliable.

--

By the way, the GHA macOS job fails randomly, I have no idea why. For
example, I saw the job being cancelled after 5 minutes for an unknown
reason. I read that a job can be cancelled if "fail fast" is used and
another job fails. It doesn't seem like we use "fail fast" and others
jobs passed successfully.

--

Links to CI changes.

Make Azure Pipelines optional on GitHub PRs:
https://bugs.python.org/issue39837

Always run GitHub action jobs, even on documentation-only jobs:
https://bugs.python.org/issue40548

Make one Windows CI job mandatory:
https://discuss.python.org/t/make-one-windows-ci-job-mandatory/4047

Make Travis CI (and Windows x64 ?) mandatory:
https://github.com/python/core-workflow/issues/365

Make Windows (x64) GitHub action mandatory on master branch:
https://github.com/python/core-workflow/issues/368

--

It's so hard to get a bunch of reliable CIs on many platforms (Linux,
Windows, macOS) and minimize the failure rate :-(

Victor
-- 
Night gathers, and now my watch begins. It shall not end until my death.
___
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-le...@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at 
https://mail.python.org/archives/list/python-committers@python.org/message/B6WVI254L7GEOCKUOHZ6XBZD4GCLAIBV/
Code of Conduct: https://www.python.org/psf/codeofconduct/


[python-committers] Re: Python Language Summit 2020 blog posts

2020-05-15 Thread Antoine Pitrou

Thank you for the blog posts!

Regards

Antoine.


Le 14/05/2020 à 20:19, Mariatta a écrit :
> The rest of Python Language Summit articles are now out:
> 
> Property-Based Testing for Python Builtins and the Standard Library, Zac
> Hatfield-Dodds: 
> https://pyfound.blogspot.com/2020/05/property-based-testing-for-python.html
> 
> Core Workflow Updates, Mariatta
> Wijaya: 
> https://pyfound.blogspot.com/2020/05/core-workflow-updates-python-language.html
> 
> CPython on Mobile Platforms, Russell
> Keith-Magee: 
> https://pyfound.blogspot.com/2020/05/cpython-on-mobile-platforms.html
> 
> Lightning talks:
> (https://pyfound.blogspot.com/2020/05/lightning-talks-part-2.html)
> - Teaching Python with Errors by Zac Hatfield-Dodds
> - State of Jython by Jim Baker
> - Read the Docs features of interest by Eric Holscher
> 
> Enjoy!
> 
> On Fri, May 1, 2020 at 10:02 AM Mariatta  > wrote:
> 
> Few more lightning talks from Eric Holscher and Zac Hatfield-Dodds
> 
> 
> ... and Jim Baker
> 
> 
> 
> 
> ___
> python-committers mailing list -- python-committers@python.org
> To unsubscribe send an email to python-committers-le...@python.org
> https://mail.python.org/mailman3/lists/python-committers.python.org/
> Message archived at 
> https://mail.python.org/archives/list/python-committers@python.org/message/OUR2XU34GPQB2G7LAGPQFX7KVYHAW4AL/
> Code of Conduct: https://www.python.org/psf/codeofconduct/
> 
___
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-le...@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at 
https://mail.python.org/archives/list/python-committers@python.org/message/FTFC7OLXLHVJISMSXWAQQZNVK6VPJDA7/
Code of Conduct: https://www.python.org/psf/codeofconduct/


[python-committers] Core Workflow change: new commit to previously approved PR now requires re-review

2020-05-15 Thread Mariatta
X-post to python-committers, python-dev, and core-workflow mailing list

I have just deployed a change to bedevere-bot to address the security
concern related to automerging.(
https://github.com/python/core-workflow/issues/325)

Previously, if core dev has approved the PR and applied the "automerge"
label, the PR will be automatically merged as soon as all the required CI
checks passed. If the PR author added another commit after the PR has been
approved but before the automerge happened, the additional commit will get
merged in without additional review.

Now, if there is a new commit after the PR has been approved, it will not
be automerged until the the core dev re-reviews it. bedevere will remove
the "awaiting merge" label and apply the "awaiting core review" label.

Hope this all makes sense. And if you see any of the bot misbehaving,
please open a ticket either in core-workflow repo or in the bot's own repo.

Thanks.
___
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-le...@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at 
https://mail.python.org/archives/list/python-committers@python.org/message/KQZFJ3GJWMQ6TBNIYC6T2ZVAXBCV3KXS/
Code of Conduct: https://www.python.org/psf/codeofconduct/