Re: [python-committers] cherry picking, miss islington, and generated files

On 5 February 2018 at 14:47, Mariatta Wijaya wrote: >> We already have Travis checking 'make regen-all' and 'make clinic' >> (assuming it's working correctly). Ah, I didn't think that idea was a new one :) > The CI in https://github.com/python/cpython/pull/5498 were

Re: [python-committers] cherry picking, miss islington, and generated files

Maybe we should just do a diff if https://github.com/python/ cpython/pull/5498 and https://github.com/python/cpython/pull/5503 are identical.. Mariatta Wijaya ___ python-committers mailing list

Re: [python-committers] cherry picking, miss islington, and generated files

On Feb 5, 2018, at 09:09, Nick Coghlan wrote: > > Heh, I think I have a plausible theory as to what happened: > > The 3.7 and 3.8 compilers are currently still identical, and this was > the first post-branch change to importlib (as far as I know), so: > > 1. The patch

[python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

Hi, I will have some time in the next couple weeks to work on miss-islington. I'm thinking to work on this issue: https://github.com/python/miss-islington/issues/44 The idea is to have miss-islington automatically merge the backport PR, after all CI passed and after a core dev approved the PR. I

Re: [python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

I like to seek one clarification. I know git has author as well as committer. I am assuming that even if miss-islington backports the PR, the author'ship of the patch is still preserved. Is that correct? Thank you, Senthil On Mon, Feb 5, 2018 at 6:18 AM, Senthil Kumaran

Re: [python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

Great idea. Definitely, +1. On Mon, Feb 5, 2018 at 6:07 AM, Mariatta Wijaya wrote: > Hi, > > I will have some time in the next couple weeks to work on miss-islington. > I'm thinking to work on this issue: https://github.com/ > python/miss-islington/issues/44 > > The

Re: [python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

On Mon, Feb 5, 2018 at 9:28 AM, Senthil Kumaran wrote: > I like to seek one clarification. > > I know git has author as well as committer. I am assuming that even if > miss-islington backports the PR, the author'ship of the patch is still > preserved. > > Is that correct? >

Re: [python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

On 6 February 2018 at 00:07, Mariatta Wijaya wrote: > Some notes and implicationss: > > - The expectation is that the commit message has already been cleaned up on > the master branch > - It already knows how to replace the # to GH- in the commit message > -

Re: [python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

On 2/5/2018 9:34 AM, Nick Coghlan wrote: On 6 February 2018 at 00:07, Mariatta Wijaya wrote: Some notes and implicationss: - The expectation is that the commit message has already been cleaned up on the master branch and that Miss Islington has correctly copied