On 31.03.2021 16:29, Ethan Furman wrote:
> On 3/31/21 6:59 AM, M.-A. Lemburg wrote:
>
>> It seems that some of the doc tests are missing imports of
>> e.g. Flag from enum.
>
> My understanding of doctest is that the global execution environment is
> cumulative. For example. the three previous
On 3/31/21 7:29 AM, Ethan Furman wrote:
Also note that the tests pass fine locally, suggesting that this is a CI
problem. [1]
I added (re)imports of Flag to those tests, and it's going through CI now.
--
~Ethan~
___
python-committers mailing list
On 3/31/21 6:59 AM, M.-A. Lemburg wrote:
It seems that some of the doc tests are missing imports of
e.g. Flag from enum.
My understanding of doctest is that the global execution environment is
cumulative. For example. the three previous tests, which all pass, are also
not reimporting Flag.
On 31.03.2021 15:54, Ethan Furman wrote:
> Because I could not find any error in the documentation that would cause the
> problem (the first three cases succeeded, using the same construct).
>
>> Why is that even allowed?
>
> Because the tests are not perfect.
>
> I did post a message to
On 3/31/21 3:52 AM, Mark Shannon wrote:
My PR tests are failing seemingly due to some bug in enum.rst
Which might be caused by https://github.com/python/cpython/pull/22392
(that's the superficial cause, it might not be the root cause).
As far as I can tell, it is not the root cause. I (and
Doesn't the automerge label block on failing CI? I think that should solve the
issue you are describing.
On March 31, 2021 1:06:15 PM UTC, "Jason R. Coombs" wrote:
>One of the reasons I might be tempted to merge a pull request before the tests
>is completed is because there’s no mechanism to
One of the reasons I might be tempted to merge a pull request before the tests
is completed is because there’s no mechanism to merge a pull request after the
tests have completed (when there’s no reviewer).
I imagine it’s allowed because there still is the case where tests can fail for
some
