Re: [python-committers] cherry picking, miss islington, and generated files

On Feb 6, 2018, at 15:30, Mariatta Wijaya wrote: > So, maybe we trust the CI a little bit more now when it comes to checking if > regenerated files are needed :) Great, thanks for checking Mariatta! It definitely gives me more confidence that if the bot and CI pass, the merge will be good. I

Re: [python-committers] cherry picking, miss islington, and generated files

I compared the output from the auto backport PR, and Barry's PR where he regenerated the files: Basically comparing the two results from [1] (miss-islington) and [2] (Barry) [1] https://api.github.com/repos/python/cpython/pulls/5503/files [2] https://api.github.com/repos/python/cpython/pulls/5498

Re: [python-committers] cherry picking, miss islington, and generated files

Maybe we should just do a diff if https://github.com/python/ cpython/pull/5498 and https://github.com/python/cpython/pull/5503 are identical.. Mariatta Wijaya ___ python-committers mailing list python-c

Re: [python-committers] cherry picking, miss islington, and generated files

On Feb 5, 2018, at 09:09, Nick Coghlan wrote: > > Heh, I think I have a plausible theory as to what happened: > > The 3.7 and 3.8 compilers are currently still identical, and this was > the first post-branch change to importlib (as far as I know), so: > > 1. The patch applied cleanly (because t

Re: [python-committers] cherry picking, miss islington, and generated files

On 5 February 2018 at 14:47, Mariatta Wijaya wrote: >> We already have Travis checking 'make regen-all' and 'make clinic' >> (assuming it's working correctly). Ah, I didn't think that idea was a new one :) > The CI in https://github.com/python/cpython/pull/5498 were all passing, but > I think we

Re: [python-committers] cherry picking, miss islington, and generated files

> > We already have Travis checking 'make regen-all' and 'make clinic' > (assuming it's working correctly). The CI in https://github.com/python/cpython/pull/5498 were all passing, but I think we expected it to fail? In the end Barry regenerated the files manually. Mariatta Wijaya ___

Re: [python-committers] cherry picking, miss islington, and generated files

We already have Travis checking 'make regen-all' and 'make clinic' (assuming it's working correctly). -- Zach (On a phone) On Feb 4, 2018 9:09 PM, "Nick Coghlan" wrote: On 4 February 2018 at 00:54, Barry Warsaw wrote: > On Feb 2, 2018, at 20:40, Mariatta Wijaya wrote: >> >> Sure, I sort of as

Re: [python-committers] cherry picking, miss islington, and generated files

On 4 February 2018 at 00:54, Barry Warsaw wrote: > On Feb 2, 2018, at 20:40, Mariatta Wijaya wrote: >> >> Sure, I sort of asked this in the past: what are the generated files, how to >> identify them, is there a pattern? > > I’m not sure there’s going to be a pattern so much as a list of such fi

Re: [python-committers] cherry picking, miss islington, and generated files

On Feb 3, 2018, at 23:16, Mariatta Wijaya wrote: > > I found the related thread in core mentorship mailing list: > https://mail.python.org/mm3/archives/list/core-mentors...@python.org/thread/CNK7EWWZTDIRID7MTWLTWXU4H7IH3UIE/ FYI, core-mentorship’s archives can’t be read without a subscription.

Re: [python-committers] cherry picking, miss islington, and generated files

Thanks :) I found the related thread in core mentorship mailing list: https://mail.python.org/mm3/archives/list/core-mentors...@python.org/thread/CNK7EWWZTDIRID7MTWLTWXU4H7IH3UIE/ Guido and Victor answered, I guess I got distracted with other things and forgot to do any sort of follow up :P If I

Re: [python-committers] cherry picking, miss islington, and generated files

On 2/3/2018 9:54 AM, Barry Warsaw wrote: On Feb 2, 2018, at 20:40, Mariatta Wijaya wrote: Sure, I sort of asked this in the past: what are the generated files, how to identify them, is there a pattern? I’m not sure there’s going to be a pattern so much as a list of such files. There are a

Re: [python-committers] cherry picking, miss islington, and generated files

On Feb 2, 2018, at 20:40, Mariatta Wijaya wrote: > > Sure, I sort of asked this in the past: what are the generated files, how to > identify them, is there a pattern? I’m not sure there’s going to be a pattern so much as a list of such files. > I need to dig up that thread and find out if anyo

Re: [python-committers] cherry picking, miss islington, and generated files

Sure, I sort of asked this in the past: what are the generated files, how to identify them, is there a pattern? I need to dig up that thread and find out if anyone answered. It's been a while :) Usually there would be conflict in backport though. It was suggested that cherry-picker can regenerate