Re: apache 2.2 support

2006-02-10 Thread Justin Erenkrantz
On 2/9/06, Graham Dumpleton <[EMAIL PROTECTED]> wrote: > If I recollect, the only real issue was the implications on Win32 platform > of changing the APR_STATUS_IS_SUCCESS(s) test to (s == APR_SUCCESS), > because of Win32 the definition was originally: > > #define APR_STATUS_IS_SUCCESS(s) ((s) == A

Re: apache 2.2 support

2006-02-09 Thread Graham Dumpleton
Jim Gallacher wrote .. > Graham Dumpleton wrote: > > The next section of code has: > > > > b = APR_BRIGADE_FIRST(self->bb_in); > > > > if (b == APR_BRIGADE_SENTINEL(self->bb_in)) > > return PyString_FromString(""); > > > > Now I am assuming here that the check with APR_BRIGADE_SE

Re: apache 2.2 support

2006-02-09 Thread Jim Gallacher
Graham Dumpleton wrote: Jim Gallacher wrote .. I'd like to checkin my patch to support apache 2.2. It doesn't add any new functionality. Any objections? If I recollect, the only real issue was the implications on Win32 platform of changing the APR_STATUS_IS_SUCCESS(s) test to (s == APR_SUCCE

Re: apache 2.2 support

2006-02-09 Thread Graham Dumpleton
Jim Gallacher wrote .. > I'd like to checkin my patch to support apache 2.2. It doesn't add any > new functionality. Any objections? If I recollect, the only real issue was the implications on Win32 platform of changing the APR_STATUS_IS_SUCCESS(s) test to (s == APR_SUCCESS), because of Win32 the