Re: memory leak in request.readline()

2006-08-14 Thread Alexis Marrero
Graham, In http://svn.apache.org/viewvc/httpd/mod_python/trunk/src/ requestobject.c?view=markup&pathrev=431327, in req_readlines(): /* is there anything left in the rbuff from previous reads? */ if (self->rbuff_pos < self->rbuff_len) { /* if yes, process that first */ wh

Re: memory leak in request.readline()

2006-08-14 Thread Graham Dumpleton
On 14/08/2006, at 1:16 AM, Jim Gallacher wrote: Only ask as I have a big patch related to MODPYTHON-63 that am wanting to commit back into the repository, but don't want to be doing it if it is going to make your search harder by introducing some new memory leaks. :-) As long as you don't

Re: memory leak in request.readline()

2006-08-13 Thread Jim Gallacher
Graham Dumpleton wrote: > Where are we at with confirming these memory leaks and committing some > changes to fix them? Close. I spent quite a few hours reading through req_readline yesterday, trying to trace through all the possibilities. There are some... ah... interesting things in there that

Re: memory leak in request.readline()

2006-08-12 Thread Graham Dumpleton
Where are we at with confirming these memory leaks and committing some changes to fix them? Only ask as I have a big patch related to MODPYTHON-63 that am wanting to commit back into the repository, but don't want to be doing it if it is going to make your search harder by introducing some new

Re: memory leak in request.readline()

2006-08-11 Thread Jim Gallacher
I ran my baseline test with 500k requests, and got the following: (Note that all the figures will have an error of +/- 0.1) baseline 500k requests 1.7% So it would seem that there is not a specific problem in readline, or my test case is messed up. FYI here are my 2 handlers: def base

Re: memory leak in request.readline()

2006-08-11 Thread Jim Gallacher
I'll have some time to investigate this over the next couple of days. I ran my leaktest script for FieldStorage and readline, and FieldStorage certainly still leaks, but I'm not so sure about readline itself. baseline 1k requests1.2% readline500k requests1.6% fieldstorage

Re: memory leak in request.readline()

2006-08-11 Thread Alexis Marrero
I noticed that lines 789-793 (in the original file, $Id: requestobject.c 420297) should be moved up to line 780, 765 if (self->rbuff_pos < self->rbuff_len) { 766 767 /* if yes, process that first */ 768 while (self->rbuff_pos < self->rbuff_len) { 769

Re: memory leak in request.readline()

2006-08-10 Thread Jim Gallacher
Alexis Marrero wrote: > All, > > We are trying to nail down a memory leak that happens only when > documents are POSTed to the server. > > For testing we have a short script that does: > > while True: > dictionary_of_parameters = {'field1': 'a'*10} > post('url...', dictionary_of_para