mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Alexis Marrero
All, The current 3.1 mod_python implementation of mod_python.util.StorageField.read_to_boudary reads as follows:   203      def read_to_boundary(self, req, boundary, file):   204          delim = ""   205          line = req.readline()   206          sline = line.strip()   207          last_bound =

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Jim Gallacher
Alexis, Do you a have a small file which shows this behaviour and could be used for testing? Even better would be a function which would generate a test file. This could be included in the mod_python unit tests. Jim Alexis Marrero wrote: All, The current 3.1 mod_python implementation of

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Jim Gallacher
Alexis, I wanted to add that I'm testing your code. Alexis Marrero wrote: Let me know any comments on it and if you test it and fails please also let me know. I don't have subversion account neither I don't know how to use it thus this email. You don't need an account to use subversion ano

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Alexis Marrero
I don't have a function that creates the files but the I can point you to a file that has the problem, ironically is "Unix Haters Handbook" :) Well, at least is not the Python HH http://research.microsoft.com/~daniel/uhh-download.html It's MD5 is 9e8c42be55aac825e7a34d448044d0fe. I don't

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Nicolas Lehuen
Hi guys, In the pure "if it ain't tested, it ain't fixed" fashion, I've added a unit test for file upload to the test suite. It uploads a randomly generated 1 MB file to the server, and check that the MD5 digest returned by the server is correct. I could not reproduce Alexis' bug report this way,

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Nicolas Lehuen
OK, it looks like Alexis' fix solves the problem with ugh.pdf without breaking the other unit tests. So I think we can safely integrate his patch. Shall I do it ? Regards, Nicolas2005/11/6, Nicolas Lehuen <[EMAIL PROTECTED]>: Hi guys, In the pure "if it ain't tested, it ain't fixed" fashion, I've

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Alexis Marrero
Nicolas,Not that I'm the one to give permission whether to integrate things or not, but just to let you know I don't even have svn installed so I won't do it. At least not for a while...BTW, if there are some cherrypy developers in this mailing list, the CherryPy function that handles file uploads

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Jim Gallacher
I've been spending some quality time with hexedit, vim and a little bit of python. I can now generate a file which can be used in the unit test. The problem seems to occur when a '\r' character is right at readBlockSize boundary, which is 65368 in the current mod_python.util. I have not yet t

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Gregory (Grisha) Trubetskoy
So I guess this means we roll and vote on a 3.2.5b? Grisah On Sun, 6 Nov 2005, Nicolas Lehuen wrote: OK, it looks like Alexis' fix solves the problem with ugh.pdf without breaking the other unit tests. So I think we can safely integrate his patch. Shall I do it ? Regards, Nicolas

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Jim Gallacher
Gregory (Grisha) Trubetskoy wrote: So I guess this means we roll and vote on a 3.2.5b? As much as it pains me to say it, but yes, this is a must fixm so it's on to 3.2.5b. I think we need to do some more extensive testing on Alexis's fix before we roll 3.2.5b. His read_to_boundary is much

[jira] Reopened: (MODPYTHON-40) FieldStorage : don't stream file uploads to memory

2005-11-06 Thread Nicolas Lehuen (JIRA)
[ http://issues.apache.org/jira/browse/MODPYTHON-40?page=all ] Nicolas Lehuen reopened MODPYTHON-40: - The fix has a bug - see http://www.modpython.org/pipermail/mod_python/2005-November/019468.html and the python-dev mailing list (GMane archive ar

Re: mod_python.util.StorageField.read_to_boundary has problems in 3.1 and 3.2

2005-11-06 Thread Nicolas Lehuen
Well, I've re-read the previous code and it looks like it does almost the same thing except it is bugged :). CherryPy's implementation is almost the same except it ought to work. Jim, I've integrated your tricky file into the unit test. Alexis' version passes all tests, whereas the current version