Re: Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Nicolas Lehuen
OK, I'm currently checking in the fixes you suggested on the trunk. Too bad we cannot write a unit test that checks for memory leaks.Jim, Graham, what shall we do for the 3.2.9 release ? Shall we keep on with the current branch or backport the fixes ? Regards,Nicolas2006/7/9, Harold Ship <[EMAIL PR

[jira] Resolved: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Nicolas Lehuen (JIRA)
[ http://issues.apache.org/jira/browse/MODPYTHON-172?page=all ] Nicolas Lehuen resolved MODPYTHON-172: -- Fix Version: 3.3 Resolution: Fixed Fixed in the trunk, we need to apply changes from revision #420275 if we want to backport this into

Re: svn commit: r420275 - in /httpd/mod_python/trunk/src: _apachemodule.c requestobject.c util.c

2006-07-09 Thread Graham Dumpleton
On 09/07/2006, at 8:05 PM, [EMAIL PROTECTED] wrote: Modified: httpd/mod_python/trunk/src/requestobject.c URL: http://svn.apache.org/viewvc/httpd/mod_python/trunk/src/ requestobject.c?rev=420275&r1=420274&r2=420275&view=diff ==

Re: Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Graham Dumpleton
On 09/07/2006, at 7:46 PM, Nicolas Lehuen wrote: OK, I'm currently checking in the fixes you suggested on the trunk. Too bad we cannot write a unit test that checks for memory leaks. Jim, Graham, what shall we do for the 3.2.9 release ? Shall we keep on with the current branch or backport

Re: *** PROBABLY SPAM *** RE: Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Nicolas Lehuen
Yes, I've done the same except that I've used Py_DECREF since the references are guarded by previous non null tests.https://svn.apache.org/repos/asf/httpd/mod_python/trunk/src/util.c Regards,Nicolas2006/7/9, Harold J. Ship <[EMAIL PROTECTED]>: Just to be sure, this is the change I've made to

Re: svn commit: r420275 - in /httpd/mod_python/trunk/src: _apachemodule.c requestobject.c util.c

2006-07-09 Thread Nicolas Lehuen
Yeah, I forgot about the appendix C in the documentation. I'm going to correct this ASAP.I know about the sizehint problem, I'm currently working on it. I just wanted to fix it in a different commit to make backporting more easy. Also, I want to write a unit test for it. This should be done in a fe

[jira] Resolved: (MODPYTHON-179) req.readlines(sizehint) does not work correctly

2006-07-09 Thread Nicolas Lehuen (JIRA)
[ http://issues.apache.org/jira/browse/MODPYTHON-179?page=all ] Nicolas Lehuen resolved MODPYTHON-179: -- Fix Version: 3.3 Resolution: Fixed Fixed and added two unit tests on the trunk. Apply revision #420288 if this needs to be backported

Re: Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Harold Ship
If possible, I would like a backport release. Nicolas Lehuen lehuen.com> writes: > OK, I'm currently checking in the fixes you suggested on the trunk. Too bad we cannot write a unit test that checks for memory leaks.Jim, Graham, what shall we do for the 3.2.9 release ? Shall we keep on with the

Re: Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Jim Gallacher
Graham Dumpleton wrote: > > On 09/07/2006, at 7:46 PM, Nicolas Lehuen wrote: > >> OK, I'm currently checking in the fixes you suggested on the trunk. >> Too bad we cannot write a unit test that checks for memory leaks. >> >> Jim, Graham, what shall we do for the 3.2.9 release ? Shall we keep on >

Re: Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Jim Gallacher
Nicolas Lehuen wrote: > OK, I'm currently checking in the fixes you suggested on the trunk. Too bad > we cannot write a unit test that checks for memory leaks. I'm working on a test harness - Linux only at this point. I don't think it would be a good idea to incorporate it into the current unit t

[jira] Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Nicolas Lehuen (JIRA)
[ http://issues.apache.org/jira/browse/MODPYTHON-172?page=comments#action_12419906 ] Nicolas Lehuen commented on MODPYTHON-172: -- I've just backported the fix into the 3.2 branch. > Memory leak with util.fieldstorage using mod_python 3.2.8 on apach

Re: Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Jim Gallacher
Harold J. Ship wrote: > I presume you mean, 3.2.10? Yes. > -Original Message- > From: Jim Gallacher > +1 skip the 3.2.9 release > +1 backport to 3.2.x > +1 release 3.1.10 asap > > > >

Re: Commented: (MODPYTHON-172) Memory leak with util.fieldstorage using mod_python 3.2.8 on apache 2.0.55

2006-07-09 Thread Harold Ship
Nicolas Lehuen (JIRA apache.org> writes: > > [ http://issues.apache.org/jira/browse/MODPYTHON-172?page=comments#action_12419906 ] > > Nicolas Lehuen commented on MODPYTHON-172: > -- > > I've just backported the fix into the 3.2 branch. > > > Memor