Are we ready for 3.3.1?

2007-01-11 Thread Jim Gallacher
We don't seem to be getting any more feedback on 3.3.0b (+1's across the board), so how does everyone feel about rolling out 3.3.1 this weekend? Or should we wait another week? 3.3.0b test result summary: +1 FreeBSD 6.1, Apache 2.2.3 (mpm-prefork), Python 2.4.3,1 +1 Linux Debian 3.1 Sarge, Apa

Memory leak in req.readlines() ????

2007-01-11 Thread Graham Dumpleton
This code in req.readlines() looks a bit fishy to me and possibly leaks memory. The code in question is: rlargs = PyTuple_New(0); if (result == NULL) return PyErr_NoMemory(); line = req_readline(self, rlargs); while (line && ((linesize=PyString_Size(line))>0)) { Py