Re: [Python-Dev] Python 3, new-style classes and __class__

2011-11-19 Thread Michael Foord
On 19 November 2011 23:11, Vinay Sajip wrote: > Michael Foord voidspace.org.uk> writes: > > > That works fine in Python 3 (mock.Mock does it): > > > > >>> class Foo(object): > > ... @property > > ... def __class__(self): > > ... return int > > ... > > >>> a = Foo() > > >>> isinstance(a, i

Re: [Python-Dev] Python 3, new-style classes and __class__

2011-11-19 Thread Vinay Sajip
Michael Foord voidspace.org.uk> writes: > That works fine in Python 3 (mock.Mock does it): > > >>> class Foo(object): > ... @property > ... def __class__(self): > ... return int > ... > >>> a = Foo() > >>> isinstance(a, int) > True > >>> a.__class__ > > > There must be something else g

Re: [Python-Dev] Python 3, new-style classes and __class__

2011-11-19 Thread Michael Foord
On 19/11/2011 22:06, Vinay Sajip wrote: I was looking through the errors which occur when running the test suite of Django's py3k branch under Python 3, and one particular set of errors caught my eye which is unrelated to the bytes/str dance. These errors occur in some Django utility code, which

Re: [Python-Dev] patch metadata - to use or not to use?

2011-11-19 Thread Ned Deily
In article , Dirkjan Ochtman wrote: > On Sat, Nov 19, 2011 at 20:41, Petri Lehtinen wrote: > >> Generally speaking, it's more useful for the checkin metadata to > >> reflect who actually did the checkin, since that's the most useful > >> information for the tracker and buildbot integration. > >

Re: [Python-Dev] patch metadata - to use or not to use?

2011-11-19 Thread Dirkjan Ochtman
On Sat, Nov 19, 2011 at 20:41, Petri Lehtinen wrote: >> Generally speaking, it's more useful for the checkin metadata to >> reflect who actually did the checkin, since that's the most useful >> information for the tracker and buildbot integration. > > At least in git, the commit metadata contains

Re: [Python-Dev] patch metadata - to use or not to use?

2011-11-19 Thread Petri Lehtinen
Nick Coghlan wrote: > Generally speaking, it's more useful for the checkin metadata to > reflect who actually did the checkin, since that's the most useful > information for the tracker and buildbot integration. At least in git, the commit metadata contains both author and committer (at least if t

Re: [Python-Dev] patch metadata - to use or not to use?

2011-11-19 Thread Guido van Rossum
On Sat, Nov 19, 2011 at 2:52 AM, Nick Coghlan wrote: > On Sat, Nov 19, 2011 at 6:42 PM, Stefan Behnel wrote: >> Hi, >> >> I recently got some patches accepted for inclusion in 3.3, and each time, >> the patch metadata (such as my name and my commit comment) were stripped by >> applying the patch

Re: [Python-Dev] patch metadata - to use or not to use?

2011-11-19 Thread Nick Coghlan
On Sat, Nov 19, 2011 at 6:42 PM, Stefan Behnel wrote: > Hi, > > I recently got some patches accepted for inclusion in 3.3, and each time, > the patch metadata (such as my name and my commit comment) were stripped by > applying the patch manually, instead of hg importing it. This makes it clear > i

Re: [Python-Dev] patch metadata - to use or not to use?

2011-11-19 Thread Antoine Pitrou
On Sat, 19 Nov 2011 09:42:49 +0100 Stefan Behnel wrote: > > I didn't see this mentioned in the dev-guide. Is it being considered the > Right Way To Do It? That said, to answer your question more generally, I think it's simply how we worked with SVN, and we haven't found any compelling reason to

Re: [Python-Dev] patch metadata - to use or not to use?

2011-11-19 Thread Antoine Pitrou
On Sat, 19 Nov 2011 09:42:49 +0100 Stefan Behnel wrote: > Hi, > > I recently got some patches accepted for inclusion in 3.3, and each time, > the patch metadata (such as my name and my commit comment) were stripped by > applying the patch manually, instead of hg importing it. This makes it > c

Re: [Python-Dev] Committing PEP 3155

2011-11-19 Thread Antoine Pitrou
On Sat, 19 Nov 2011 03:31:09 +0100 Victor Stinner wrote: > > I haven't seen any strong objections, so I would like to go ahead and > > commit PEP 3155 (*) soon. Is anyone against it? > > I'm not against it, but I have some questions. > > Does you a working implementing? I suppose the question i

[Python-Dev] patch metadata - to use or not to use?

2011-11-19 Thread Stefan Behnel
Hi, I recently got some patches accepted for inclusion in 3.3, and each time, the patch metadata (such as my name and my commit comment) were stripped by applying the patch manually, instead of hg importing it. This makes it clear in the history who eventually reviewed and applied the patch, b

Re: [Python-Dev] Committing PEP 3155

2011-11-19 Thread Nick Coghlan
On Sat, Nov 19, 2011 at 4:48 PM, Serhiy Storchaka wrote: > 19.11.11 01:54, Antoine Pitrou написав(ла): >> >> Well, the other propositions still seem worse to me. "Qualified" is >> reasonably accurate, and "qualname" is fairly short and convenient (I >> would hate to type "__qualifiedname__" or "__