Re: [Python-Dev] please back out changeset f903cf864191 before alpha-2

2013-08-23 Thread Nick Coghlan
On 24 August 2013 15:32, Stefan Behnel wrote: > So, to put it more nicely, I think this feature was added without the > amount of review that it needs, and now that I've given it that review, I'm > asking for removal of the feature and a proper redesign that fits into the > existing library. FWIW

Re: [Python-Dev] Pre-PEP: Redesigning extension modules

2013-08-23 Thread Nick Coghlan
On 23 August 2013 19:18, Antoine Pitrou wrote: > > Hi, > > Le Fri, 23 Aug 2013 10:50:18 +0200, > Stefan Behnel a écrit : >> >> Here's an initial attempt at a PEP for it. It is based on the >> (unfinished) ModuleSpec PEP, which is being discussed on the >> import-sig mailing list. > > Thanks for t

Re: [Python-Dev] please back out changeset f903cf864191 before alpha-2

2013-08-23 Thread Stefan Behnel
Antoine Pitrou, 24.08.2013 01:26: > On Sat, 24 Aug 2013 00:57:48 +0200 > Stefan Behnel wrote: >> ticket 17741 has introduced a new feature in the xml.etree.ElementTree >> module that was added without any major review. >> >> http://bugs.python.org/issue17741 > > As I've already indicated on the tr

Re: [Python-Dev] please back out changeset f903cf864191 before alpha-2

2013-08-23 Thread Antoine Pitrou
On Sat, 24 Aug 2013 00:57:48 +0200 Stefan Behnel wrote: > Hi, > > ticket 17741 has introduced a new feature in the xml.etree.ElementTree > module that was added without any major review. > > http://bugs.python.org/issue17741 As I've already indicated on the tracker, I'm completely saturated wit

[Python-Dev] please back out changeset f903cf864191 before alpha-2

2013-08-23 Thread Stefan Behnel
Hi, ticket 17741 has introduced a new feature in the xml.etree.ElementTree module that was added without any major review. http://bugs.python.org/issue17741 http://hg.python.org/cpython/rev/f903cf864191 I only recently learned about this addition and after taking a couple of closer looks, I fou

Re: [Python-Dev] PEP 446 (make FD non inheritable) ready for a final review

2013-08-23 Thread Charles-François Natali
> About your example: I'm not sure that it is reliable/portable. I sa > daemon libraries closing *all* file descriptors and then expecting new > file descriptors to become 0, 1 and 2. Your example is different > because w is still open. On Windows, I have seen cases with only fd 0, > 1, 2 open, and

Re: [Python-Dev] [Python-checkins] cpython (merge 3.3 -> default): merge for issue #18755

2013-08-23 Thread Brett Cannon
I explicitly did a second merge, reverted Misc/NEWS and committed, so that shouldn't have come up. It's not a big deal having the entry, but I didn't worry about it either. On Fri, Aug 23, 2013 at 1:26 PM, Victor Stinner wrote: > 2013/8/23 brett.cannon : > > http://hg.python.org/cpython/rev/7d30

[Python-Dev] Benchmarks now run unmodified under Python 3

2013-08-23 Thread Brett Cannon
I just committed a change to the benchmarks suite so that there is no longer a translation step to allow running under Python 3. Should make it much easier to just keep a checkout lying around to use for both Python 2 and 3 benchmarking. ___ Python-Dev ma

Re: [Python-Dev] [Python-checkins] cpython (merge 3.3 -> default): merge for issue #18755

2013-08-23 Thread Victor Stinner
2013/8/23 brett.cannon : > http://hg.python.org/cpython/rev/7d30ecf5c916 > changeset: 85339:7d30ecf5c916 > parent: 85336:391f36ef461a > parent: 85337:ddd610cb65ef > user:Brett Cannon > date:Fri Aug 23 11:52:19 2013 -0400 > summary: > merge for issue #18755 > > files:

Re: [Python-Dev] PEP 446 (make FD non inheritable) ready for a final review

2013-08-23 Thread Victor Stinner
Hi, I will try to answer to your worries. Tell me if I should complete the PEP with these answers. 2013/8/23 Charles-François Natali : > Why does dup2() create inheritable FD, and not dup()? Ah yes, there were as section explaining it. In a previous version of the PEP (and its implementation), o

[Python-Dev] Summary of Python tracker Issues

2013-08-23 Thread Python tracker
ACTIVITY SUMMARY (2013-08-16 - 2013-08-23) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open4168 (+16) closed 26426 (+49) total 30594 (+65) Open issues wit

Re: [Python-Dev] Pre-PEP: Redesigning extension modules

2013-08-23 Thread Antoine Pitrou
Hi, Le Fri, 23 Aug 2013 10:50:18 +0200, Stefan Behnel a écrit : > > Here's an initial attempt at a PEP for it. It is based on the > (unfinished) ModuleSpec PEP, which is being discussed on the > import-sig mailing list. Thanks for trying this. I think the PEP should contain working example cod

[Python-Dev] Pre-PEP: Redesigning extension modules

2013-08-23 Thread Stefan Behnel
Hi, this has been subject to a couple of threads on python-dev already, for example: http://thread.gmane.org/gmane.comp.python.devel/135764/focus=140986 http://thread.gmane.org/gmane.comp.python.devel/141037/focus=141046 It originally came out of issues 13429 and 16392. http://bugs.python.org/

Re: [Python-Dev] PEP 446 (make FD non inheritable) ready for a final review

2013-08-23 Thread Charles-François Natali
Hello, A couple remarks: > The following functions are modified to make newly created file descriptors > non-inheritable by default: > [...] > os.dup() then > os.dup2() has a new optional inheritable parameter: os.dup2(fd, fd2, > inheritable=True). fd2 is created inheritable by default, but n