Re: [Python-Dev] bitwise operations for bytes and bytearray

2016-01-09 Thread Martin Panter
On 10 January 2016 at 00:17, Blake Griffith wrote: > A little update, I got ^, &, and | working for bytearrays. You can view the > diff here: > https://github.com/python/cpython/compare/master...cowlicks:bitwise-bytes?expand=1 > > How does it look? I left some comments against your commits on Git

Re: [Python-Dev] bitwise operations for bytes and bytearray

2016-01-09 Thread Andrew Barnert via Python-Dev
On Jan 9, 2016, at 16:17, Blake Griffith wrote: > > A little update, I got ^, &, and | working for bytearrays. You can view the > diff here: > https://github.com/python/cpython/compare/master...cowlicks:bitwise-bytes?expand=1 If you upload the diff to the issue on the tracker, the reitveld code

Re: [Python-Dev] bitwise operations for bytes and bytearray

2016-01-09 Thread Blake Griffith
A little update, I got ^, &, and | working for bytearrays. You can view the diff here: https://github.com/python/cpython/compare/master...cowlicks:bitwise-bytes?expand=1 How does it look? Joe, is this how I should allocate the arrays? Am I freeing them properly? Am I checking the input enough? Af