Re: [Python-Dev] The devguide is now hosted on GitHub

2016-07-22 Thread Benjamin Peterson
Should we just make the RTD one canonical and serve redirects on docs.python.org? On Fri, Jul 22, 2016, at 13:04, Brett Cannon wrote: > https://github.com/python/devguide > > I have also moved all issues over as well and hooked up Read The Docs so > that there's a mirror which is always up-to-dat

Re: [Python-Dev] Convert from unsigned long long to PyLong

2016-07-22 Thread Tian JiaLin
Hey Guys, I found the mistake I made, basically I'm using a tool called Sentry to capture the exceptions. The value returned from the Python is 2^64-1, which is -1 from mysql_affected_rows. Sentry is using JSON format as the a kind of storage, apparently the MAX SAFE INTEGER

Re: [Python-Dev] Should we fix these errors?

2016-07-22 Thread Christian Heimes
On 2016-07-22 17:31, Chris Angelico wrote: > On Sat, Jul 23, 2016 at 12:36 AM, Guido van Rossum wrote: >> Somebody did some research and found some bugs in CPython (IIUC). The >> published some questionable fragments. If there's a volunteer we could >> probably easily fix these. (I know we already

Re: [Python-Dev] The devguide is now hosted on GitHub

2016-07-22 Thread Wes Turner
https://cpython-devguide.readthedocs.io/ Thanks! On Friday, July 22, 2016, Brett Cannon wrote: > It's in the README of the repo, but it's > http://cpython-devguide.readthedocs.io/ > > On Fri, 22 Jul 2016 at 14:09 Tres Seaver > wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >>

Re: [Python-Dev] The devguide is now hosted on GitHub

2016-07-22 Thread Brett Cannon
It's in the README of the repo, but it's http://cpython-devguide.readthedocs.io/ On Fri, 22 Jul 2016 at 14:09 Tres Seaver wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/22/2016 04:04 PM, Brett Cannon wrote: > > https://github.com/python/devguide > > > > I have also moved all

Re: [Python-Dev] The devguide is now hosted on GitHub

2016-07-22 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/22/2016 04:04 PM, Brett Cannon wrote: > https://github.com/python/devguide > > I have also moved all issues over as well and hooked up Read The Docs > so that there's a mirror which is always up-to-date (vs. > docs.python.org/devguide which is

Re: [Python-Dev] The devguide is now hosted on GitHub

2016-07-22 Thread Stephane Wirtel
Congratulations Brett, Thank you so much for this job. > On 22 juil. 2016, at 10:04 PM, Brett Cannon wrote: > > https://github.com/python/devguide > > I have also moved all issues over as well and hooked up Read The Docs so that > there's a mirror which is always up-to-date (vs. docs.python.o

Re: [Python-Dev] The devguide is now hosted on GitHub

2016-07-22 Thread Eric Snow
Thanks for doing all this, Brett. :) -eric On Fri, Jul 22, 2016 at 2:04 PM, Brett Cannon wrote: > https://github.com/python/devguide > > I have also moved all issues over as well and hooked up Read The Docs so > that there's a mirror which is always up-to-date (vs. > docs.python.org/devguide whi

[Python-Dev] The devguide is now hosted on GitHub

2016-07-22 Thread Brett Cannon
https://github.com/python/devguide I have also moved all issues over as well and hooked up Read The Docs so that there's a mirror which is always up-to-date (vs. docs.python.org/devguide which is on a cronjob). ___ Python-Dev mailing list Python-Dev@pyth

Re: [Python-Dev] Should we fix these errors?

2016-07-22 Thread Victor Stinner
2016-07-22 18:21 GMT+02:00 Random832 : >> I just fixed it: >> https://hg.python.org/cpython/rev/6c11f52ab9db > > Does INVALID_SOCKET exist on non-windows systems? Yes, it was already used in almost all places. When I read again the code, in fact I found other places with "fd < 0" or "fd = -1". I

Re: [Python-Dev] Convert from unsigned long long to PyLong

2016-07-22 Thread Random832
On Fri, Jul 22, 2016, at 11:50, Eric Snow wrote: > On Fri, Jul 22, 2016 at 3:02 AM, Stefan Ring wrote: > > So to sum this up, you claim that PyLong_FromUnsignedLongLong can > > somehow produce a number larger than the value range of a 64 bit > > number (0x10180). I have a hard time bel

Re: [Python-Dev] Should we fix these errors?

2016-07-22 Thread Random832
On Fri, Jul 22, 2016, at 11:35, Victor Stinner wrote: > Oh, the first one is a regression that I introduced in the > implementation of the PEP 475 (retry syscall on EINTR). I don't think > that it can be triggered in practice, because socket handles on > Windows are small numbers, so unlikely to be

Re: [Python-Dev] Convert from unsigned long long to PyLong

2016-07-22 Thread Tian JiaLin
Yes, you are right. Definitely "long" in Python can represent a number much bigger than the native. But the range of returned value from mysql_affected_rows within 0 ~ 2^64-1. No matter how it's converted, the converted value in Python also should in the range of 0 ~ 2^64 - 1. On Fri, Jul 22, 20

[Python-Dev] Summary of Python tracker Issues

2016-07-22 Thread Python tracker
ACTIVITY SUMMARY (2016-07-15 - 2016-07-22) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open5586 (+24) closed 33762 (+47) total 39348 (+71) Open issues wit

Re: [Python-Dev] Convert from unsigned long long to PyLong

2016-07-22 Thread Eric Snow
On Fri, Jul 22, 2016 at 3:02 AM, Stefan Ring wrote: > So to sum this up, you claim that PyLong_FromUnsignedLongLong can > somehow produce a number larger than the value range of a 64 bit > number (0x10180). I have a hard time believing this. Perhaps I misunderstood your meaning, but P

Re: [Python-Dev] Should we fix these errors?

2016-07-22 Thread Victor Stinner
Oh, the first one is a regression that I introduced in the implementation of the PEP 475 (retry syscall on EINTR). I don't think that it can be triggered in practice, because socket handles on Windows are small numbers, so unlikely to be seen as negative. I just fixed it: https://hg.python.org/cpy

Re: [Python-Dev] Should we fix these errors?

2016-07-22 Thread Chris Angelico
On Sat, Jul 23, 2016 at 12:36 AM, Guido van Rossum wrote: > Somebody did some research and found some bugs in CPython (IIUC). The > published some questionable fragments. If there's a volunteer we could > probably easily fix these. (I know we already have occasional Coverity > scans and there are

Re: [Python-Dev] Convert from unsigned long long to PyLong

2016-07-22 Thread Tian JiaLin
I know it's hard to believe this, I wish I'm wrong. But after looking into the code for one week, I didn't find any other code change the number. I will go through them again make sure I didn't miss anything. Thanks for the reply. On Fri, Jul 22, 2016 at 5:02 PM, Stefan Ring wrote: > So to sum

[Python-Dev] Should we fix these errors?

2016-07-22 Thread Guido van Rossum
Somebody did some research and found some bugs in CPython (IIUC). The published some questionable fragments. If there's a volunteer we could probably easily fix these. (I know we already have occasional Coverity scans and there are other tools too (anybody try lgtm yet?) But this seems honest resea

Re: [Python-Dev] Convert from unsigned long long to PyLong

2016-07-22 Thread Stefan Ring
So to sum this up, you claim that PyLong_FromUnsignedLongLong can somehow produce a number larger than the value range of a 64 bit number (0x10180). I have a hard time believing this. Most likely you are looking in the wrong place, mysql_affected_rows returns 2^64-1, and some Python co