Re: [Python-Dev] Regarding writing tests for module tabnanny

2017-03-13 Thread Martin Panter
On 13 March 2017 at 11:56, Jaysinh Shukla wrote: > Respected Members, > > I identified the standard module 'tabnanny' is having 16.66% of code > coverage (Source: > https://codecov.io/gh/python/cpython/src/master/Lib/tabnanny.py). I am > interested to write tests for this

Re: [Python-Dev] Regarding writing tests for module tabnanny

2017-03-13 Thread Brett Cannon
These questions are best asked on the core-mentorship mailing list, Jaysinh, but to quickly answer your question: 1. Yes, tests would be appreciated. 2. Nothing from me On Mon, 13 Mar 2017 at 08:20 Jaysinh Shukla wrote: > Respected Members, > > I identified the

[Python-Dev] Regarding writing tests for module tabnanny

2017-03-13 Thread Jaysinh Shukla
Respected Members, I identified the standard module 'tabnanny' is having 16.66% of code coverage (Source: https://codecov.io/gh/python/cpython/src/master/Lib/tabnanny.py). I am interested to write tests for this module. Before starting, I would like to get help from any core developer on

Re: [Python-Dev] PEP 538: Coercing the legacy C locale to a UTF-8 based locale

2017-03-13 Thread INADA Naoki
On Mon, Mar 13, 2017 at 10:31 PM, Random832 wrote: > On Mon, Mar 13, 2017, at 04:37, INADA Naoki wrote: >> But locale coercing works nice on platforms like android. >> So how about simplified version of PEP 538? Just adding configure >> option for locale coercing >> which

Re: [Python-Dev] PEP 538: Coercing the legacy C locale to a UTF-8 based locale

2017-03-13 Thread INADA Naoki
On Mon, Mar 13, 2017 at 8:01 PM, Nick Coghlan wrote: > On 13 March 2017 at 18:37, INADA Naoki wrote: >> >> But locale coercing works nice on platforms like android. >> So how about simplified version of PEP 538? Just adding configure >> option for

Re: [Python-Dev] PEP 538: Coercing the legacy C locale to a UTF-8 based locale

2017-03-13 Thread Nick Coghlan
On 13 March 2017 at 18:37, INADA Naoki wrote: > But locale coercing works nice on platforms like android. > So how about simplified version of PEP 538? Just adding configure > option for locale coercing > which is disabled by default. No envvar options and no warnings.

Re: [Python-Dev] PEP 538: Coercing the legacy C locale to a UTF-8 based locale

2017-03-13 Thread INADA Naoki
> It seems to based on an assumption that the C locale is always some kind of > pathology. Admittedly, it sometimes is a result of misconfiguration or a > mistake. (But I don't see why it's the interpreter's job to correct such > mistakes.) However, in some cases the C locale is a normal