Re: [Python-Dev] Rename Include/internals/ to Include/pycore/

2018-10-28 Thread Benjamin Peterson
On Sun, Oct 28, 2018, at 14:30, Victor Stinner wrote: > Le dim. 28 oct. 2018 à 21:50, Benjamin Peterson a écrit > : > > I don't think more or less API should be magically included based on > > whether Py_BUILD_CORE is defined or not. If we want to have private > > headers, we should include t

Re: [Python-Dev] Rename Include/internals/ to Include/pycore/

2018-10-28 Thread Victor Stinner
Le dim. 28 oct. 2018 à 21:50, Benjamin Peterson a écrit : > I don't think more or less API should be magically included based on whether > Py_BUILD_CORE is defined or not. If we want to have private headers, we > should include them where needed and not install them. Really, Py_BUILD_CORE > sho

Re: [Python-Dev] Rename Include/internals/ to Include/pycore/

2018-10-28 Thread Benjamin Peterson
On Sun, Oct 28, 2018, at 09:20, Victor Stinner wrote: > Hi, > > Python C API has no strict separation between the 3 levels of API: > > * core: Py_BUILD_CORE define > * stable: Py_LIMITED_API define (it has a value) > * regular: no define > > IMHO the current design of header files is done bac

Re: [Python-Dev] Rename Include/internals/ to Include/pycore/

2018-10-28 Thread Victor Stinner
Oh, I forgot to add a reference to the bugs.python.org issue and my pull request! * https://bugs.python.org/issue35081 * https://github.com/python/cpython/pull/10143 My PR more or less implements the first milestone of my plan (Py_BUILD_CORE): it creates Include/pycore/. Victor Le dim. 28 oct. 2

[Python-Dev] Rename Include/internals/ to Include/pycore/

2018-10-28 Thread Victor Stinner
Hi, Python C API has no strict separation between the 3 levels of API: * core: Py_BUILD_CORE define * stable: Py_LIMITED_API define (it has a value) * regular: no define IMHO the current design of header files is done backward: by default, everything is public. To exclude an API from core or sta