Re: [Python-Dev] Standardize error message for non-pickleable types

2018-10-30 Thread MRAB
On 2018-10-30 08:12, Serhiy Storchaka wrote: 29.10.18 23:17, MRAB пише: 1. If you're pickling, then saying "pickle" is more helpful. 2. In English the usual long form is "cannot". Error messages tend to avoid abbreviations, and also tend to have lowercase after the colon, e.g.:    

Re: [Python-Dev] Standardize error message for non-pickleable types

2018-10-30 Thread Glenn Linderman
On 10/30/2018 1:12 AM, Serhiy Storchaka wrote: 29.10.18 23:17, MRAB пише: 1. If you're pickling, then saying "pickle" is more helpful. 2. In English the usual long form is "cannot". Error messages tend to avoid abbreviations, and also tend to have lowercase after the colon, e.g.:

Re: [Python-Dev] Rename Include/internals/ to Include/pycore/

2018-10-30 Thread Victor Stinner
Le mar. 30 oct. 2018 à 02:59, Benjamin Peterson a écrit : > > To me, it seems wrong that a function or macro defined in > > Include/objimpl.h requires an explicit #include "internal/pystate.h". > > objimpl.h should be self-sufficient. > > I agree. I would say nothing in Include/*.h should be

Re: [Python-Dev] Custom AIX build last week...

2018-10-30 Thread Victor Stinner
I used a custom build to check if a fix repaired a buildbot. It's unrelated to AIX, but inlining on Visual Studio in Debug mode, so specific to Windows. Victor Le mar. 30 oct. 2018 à 07:11, Michael Felt a écrit : > > I noticed that there was a "custom" build queued for my AIX build-bot last >

Re: [Python-Dev] Standardize error message for non-pickleable types

2018-10-30 Thread Victor Stinner
Le lun. 29 oct. 2018 à 22:20, MRAB a écrit : > 1. If you're pickling, then saying "pickle" is more helpful. I'm not sure that it's really possible to know if the error occurs while pickle is trying to serialize an object, or if it's a different serialization protocol. We are talking about the

Re: [Python-Dev] Standardize error message for non-pickleable types

2018-10-30 Thread Serhiy Storchaka
29.10.18 23:17, MRAB пише: 1. If you're pickling, then saying "pickle" is more helpful. 2. In English the usual long form is "cannot". Error messages tend to avoid abbreviations, and also tend to have lowercase after the colon, e.g.:     "ZeroDivisionError: division by zero"    

Re: [Python-Dev] Julien Palard joins the Python Release Team as Documentation Expert

2018-10-30 Thread Christian Heimes
On 30/10/2018 04.04, Ned Deily wrote: > https://discuss.python.org/t/julien-palard-joins-the-python-release-team-as-documentation-expert/313 Welcome on board, Julien! Thank you very much for helping out. ___ Python-Dev mailing list

Re: [Python-Dev] Custom AIX build last week...

2018-10-30 Thread Michael Felt
I did a bit of digging and it seems this is related to issue35059, and something about "inline" processing. Besides learning how to clone a PR manually (which I will need to do) - what are you hoping to find? As my bot is not using gcc ( but xlc) I could look at manually compiling a single

[Python-Dev] Custom AIX build last week...

2018-10-30 Thread Michael Felt
I noticed that there was a "custom" build queued for my AIX build-bot last week. (https://buildbot.python.org/all/#/builders/159/builds/1). It failed, but I hope that was due to the issue with install.sh. If it could be run again - and if it fails again, please let me know what the test was,