Re: [Python-Dev] Tests for internal functionality

2019-03-16 Thread Terry Reedy
On 3/16/2019 3:10 AM, Ivan Pozdeev via Python-Dev wrote: In https://github.com/python/cpython/pull/6541 , I was requested to add tests for an internal C function. As I wrote in https://github.com/python/cpython/pull/6541#issuecomment-445514807 , it's not clear from the codebase 1) where tes

Re: [Python-Dev] Reject PEP 472: Support for indexing with keyword arguments

2019-03-16 Thread Stefano Borini
Hello, I am one of the authors of the PEP. I agree with your sentiment. I still think it might be useful in some contexts and I got some positive reactions here and there, but as you said it does not seem to provide a lot of added value. On Fri, 15 Mar 2019 at 21:50, Brett Cannon wrote: > The i

Re: [Python-Dev] Deferring PEP 536 -- Final Grammar for Literal String Interpolation

2019-03-16 Thread Philipp Angerer
Sorry for not having one, but my C is really not up to speed. Help is therefore very welcome of course! Am Fr., 15. März 2019 um 23:32 Uhr schrieb Brett Cannon : > The steering council decided to defer PEP 536 until an implementation is > available. >

[Python-Dev] Tests for internal functionality

2019-03-16 Thread Ivan Pozdeev via Python-Dev
In https://github.com/python/cpython/pull/6541 , I was requested to add tests for an internal C function. As I wrote in https://github.com/python/cpython/pull/6541#issuecomment-445514807 , it's not clear from the codebase 1) where tests for internal (as opposed to public) functionality should

[Python-Dev] Rejecting PEP 473: Adding structured data to built-in exceptions

2019-03-16 Thread Victor Stinner
Hi, While I would like to get such new attributes, I see drawbacks as blocker issues and so I am fine with this PEP rejection. Performance is too critical for most common exceptions. For me one blocker issue is the high risk of creating reference cycles. And the weak reference API isn't the most