Re: [Python-Dev] More on Py3K urllib -- urlencode()

2009-03-10 Thread Dan Mahn
Ahh ... I see. I should have done a bit more digging to find where the standard tests were. I created a few new tests that could be included in that test suite -- see the attached file. Do you think that this would be sufficient? - Dan Bill Janssen wrote: Dan Mahn wrote: Yes, that

Re: [Python-Dev] More on Py3K urllib -- urlencode()

2009-03-10 Thread Dan Mahn
I submitted an explanation of this and my proposed modification as issue 5468. http://bugs.python.org/issue5468 - Dan Bill Janssen wrote: Aahz wrote: On Sat, Mar 07, 2009, Dan Mahn wrote: After a harder look, I concluded there was a bit more work to be done, but still very basic

Re: [Python-Dev] More on Py3K urllib -- urlencode()

2009-03-09 Thread Dan Mahn
wrote: On Sat, Mar 07, 2009, Dan Mahn wrote: After a harder look, I concluded there was a bit more work to be done, but still very basic modifications. Attached is a version of urlencode() which seems to make the most sense to me. I wonder how I could officially propose at leas

Re: [Python-Dev] More on Py3K urllib -- urlencode()

2009-03-07 Thread Dan Mahn
wrote: Bill Janssen wrote: Dan Mahn wrote: 3) Regarding the following code fragment in urlencode(): k = quote_plus(str(k)) if isinstance(v, str): v = quote_plus(v) l.append(k + '=' + v) elif isinsta

Re: [Python-Dev] More on Py3K urllib -- urlencode()

2009-02-28 Thread Dan Mahn
Bill Janssen wrote: Bill Janssen wrote: Dan Mahn wrote: 3) Regarding the following code fragment in urlencode(): k = quote_plus(str(k)) if isinstance(v, str): v = quote_plus(v) l.append(k + '=

[Python-Dev] More on Py3K urllib -- urlencode()

2009-02-28 Thread Dan Mahn
Hi. I've been using Py3K successfully for a while now, and have some questions about urlencode(). 1) The docs mention that items sent to urlencode() are quoted using quote_plus(). However, instances of type "bytes" are not handled like they are with quote_plus() because urlencode() converts