Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Eli Collins
On Sat, Dec 17, 2011 at 11:20 AM, Benjamin Peterson wrote: > > No. The descr will deallocate it. > > PS. Please don't send HTML mail. > Thank you for the explanation. And my apologies to the entire list for the HTML; it's way too early for me, I forgot to turn that mess off.

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Eli Collins
In that same code, right before "PY_DECREF(descr)", should there also be a "PY_XDECREF(type)"? it looks like it might leak a reference to "type" otherwise. the line in question - http://hg.python.org/cpython/file/8c355edc5b1d/Objects/descrobject.c#l628 - Eli Collins