Re: [Python-Dev] Documentation Error for __hash__

2008-08-29 Thread Matt Giuca
> Note that only instances have the default hash value id(obj). This > is not true in general. Most types don't implement the tp_hash > slot and thus are not hashable. Indeed, mutable types should not > implement that slot unless they know what they're doing :-) By "instances" you mean "instances

Re: [Python-Dev] Documentation Error for __hash__

2008-08-29 Thread Matt Giuca
> >> It's probably a good idea to implement __hash__ for objects that >> implement comparisons, but it won't always work and it is certainly >> not needed, unless you intend to use them as dictionary keys. >> >> >> > > > So you're suggesting that we document something like. > > Classes that represe

Re: [Python-Dev] Documentation Error for __hash__

2008-08-29 Thread Matt Giuca
> Being hashable is a different from being usable as dictionary key. > > Dictionaries perform the lookup based on the hash value, but will > then have to check for hash collisions based on an equal comparison. > > If an object does not define an equal comparison, then it is not > usable as dictiona

Re: [Python-Dev] Documentation Error for __hash__

2008-08-28 Thread Matt Giuca
> This may have been true for old style classes, but as new style classes > inherit a default __hash__ from object - mutable objects *will* be usable as > dictionary keys (hashed on identity) *unless* they implement a __hash__ > method that raises a type error. > I always thought this was a bug in

[Python-Dev] Fwd: Things to Know About Super

2008-08-24 Thread Matt Giuca
Had a brief offline discussion with Michele - forwarding. -- Forwarded message -- From: [EMAIL PROTECTED] <[EMAIL PROTECTED]> Date: Mon, Aug 25, 2008 at 12:13 AM On Aug 24, 3:43 pm, "Matt Giuca" <[EMAIL PROTECTED]> wrote: > Hi Michele, > > Do you h

Re: [Python-Dev] Things to Know About Super

2008-08-24 Thread Matt Giuca
Hi Michele, Do you have a URL for this blog? Matt ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] ImportError message suggestion

2008-08-19 Thread Matt Giuca
I think this is not the place to be discussing the patch (the tracker is), but while I think of it, I'll just say: You need to DECREF the fn variable (both PyObject_GetAttrStringand PyString_FromString ret

Re: [Python-Dev] ImportError message suggestion

2008-08-19 Thread Matt Giuca
> ImportError: cannot import name annotate from /usr//image.pyc That could be handy. Not sure it's necessary, however, and exposes some system information in the error message. I can imagine a web app which prints out exception messages, and this would mean the server file structure is printed t

[Python-Dev] uuid test fails

2008-08-14 Thread Matt Giuca
Hi, I thought I'd bring this up on both the tracker and mailing list, since it's important. It seems the test suite breaks as of r65661. I've posted details to the bug tracker and a patch which fixes the module in question (uuid.py). http://bugs.python.org/issue3552 Cheers Matt _

Re: [Python-Dev] bytes.tohex in Python 3

2008-08-09 Thread Matt Giuca
Hi Guido, Ah yes Martin just pointed this out on the tracker. I think it would still be worthwhile having the tohex method, if not just to counter the obscurity of the binascii.hexlify function (but for other reasons too). Also there's an issue with all the functions in binascii - they return byt

Re: [Python-Dev] bytes.tohex in Python 3

2008-08-09 Thread Matt Giuca
Well, whether there's community support for this or not, I thought I'd have a go at implementing this, so I did. I've submitted a feature request + working patch to the bug tracker: http://bugs.python.org/issue3532 Matt PS. I mean ''.join("%02x" % b for b in mybytes)

[Python-Dev] bytes.tohex in Python 3

2008-08-09 Thread Matt Giuca
Hi, I'm confused as to how you represent a bytes object in hexadecimal in Python 3. Of course in Python 2, you use str.encode('hex') to go to hex, and hexstr.decode('hex') to go from hex. In Python 3, they removed "hex" as a codec (which was a good move, I think). Now there's the static method by

Re: [Python-Dev] String concatenation

2008-08-09 Thread Matt Giuca
Is the only issue with this feature that you might accidentally miss a comma after a string in a sequence of strings? That seems like a significantly obscure scenario compared to the usefulness of the current syntax, for exactly the purpose Barry points out (which most people use all the time). I

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-08-07 Thread Matt Giuca
Wow .. a lot of replies today! On Thu, Aug 7, 2008 at 2:09 AM, "Martin v. Löwis" <[EMAIL PROTECTED]>wrote: > It hasn't been given priority: There are currently 606 patches in the > tracker, many fixing bugs of some sort. It's not clear (to me, at least) > why this should be given priority over al

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-08-06 Thread Matt Giuca
> There are a lot of quotes around. Including "After the most recent flurry > of > discussion I've lost track of what's the right thing to do." > But I don't talk for other people. > OK .. let me compose myself a little. Sorry I went ahead and assumed this was closed. It's just frustrating to me

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-08-06 Thread Matt Giuca
> This whole discussion circles too much, I think. Maybe it should be pepped? The issue isn't circular. It's been patched and tested, then a whole lot of people agreed including Guido. Then you and Bill wanted the bytes functionality back. So I wrote that in there too, and Bill at least said that

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-08-05 Thread Matt Giuca
future? I'm far less concerned about the decision with regards to unquote_to_bytes/quote_from_bytes, as those are new features which can wait. Matt Giuca ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-08-05 Thread Matt Giuca
w if there is anything I can do to speed this along. Also I'd be interested in hearing anyone's opinion on the "quote_from_bytes" issue as raised in the previous email. I posted a suggested implementation of a more restrictive quote_from_bytes in that email, but I haven't

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-31 Thread Matt Giuca
> so you can use quote_from_bytes on strings? Yes, currently. > I assumed Guido meant it was okay to have quote accept string/byte input and > have a function that was redundant but limited in what it accepted (i.e. > quote_from_bytes accepts only bytes) > > I suppose your implementation doesn'

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-31 Thread Matt Giuca
Bill wrote: I'm not sure that's sufficient review, though I agree it's necessary. > The major consumers of quote/unquote are not in the Python standard > library. I figured that Python 3.0 is designed to fix things, with the breaking third-party code being an acceptable side-effect of that. So t

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-31 Thread Matt Giuca
Alright, I've uploaded the new patch which adds the two requested bytes-oriented functions, as well as accompanying docs and tests. http://bugs.python.org/issue3300 http://bugs.python.org/file11009/parse.py.patch6 I'd rather have two pairs of functions, so that those who want to give > the readers

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-30 Thread Matt Giuca
> Con: URI encoding does not encode characters. OK, for all the people who say URI encoding does not encode characters: yes it does. This is not an encoding for binary data, it's an encoding for character data, but it's unspecified how the strings map to octets before being percent-encoded. From R

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-30 Thread Matt Giuca
Arg! Damnit, why do my replies get split off from the main thread? Sorry about any confusion this may be causing. ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mai

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-30 Thread Matt Giuca
r byte strings; possible to hack around it. Cons: unquote is not inverse of quote; quote behaviour internally-inconsistent; garbage when unquoting UTF-8-encoded URIs. 2. Default to UTF-8. In favour: Matt Giuca, Brett Cannon, Jeroen Ruigrok van der Werven Pros: Fully working and tested solution is

Re: [Python-Dev] str(container) should call str(item), not repr(item)

2008-07-28 Thread Matt Giuca
debugging. This means all my classes behave like containers currently do - their str will call repr on the items. This proposal will make all of my classes behave inconsistently with the standard container types. - Matt Giuca ___ Python-Dev mailing list Python

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-13 Thread Matt Giuca
On Mon, Jul 14, 2008 at 4:54 AM, André Malo <[EMAIL PROTECTED]> wrote: > > Ahem. The HTTP standard does ;-) > Really? Can you include a quotation please? The HTTP standard talks a lot about ISO-8859-1 (Latin-1) in terms of actually raw encoded bytes, but not in terms of URI percent-encoding (a di

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-12 Thread Matt Giuca
> This POV is way too browser-centric... > This is but one example. Note that I found web forms to be the least clear-cut example of choosing an encoding. Most of the time applications seem to be using UTF-8, and all the standards I have read are moving towards specifying UTF-8 (from being unspeci

Re: [Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-12 Thread Matt Giuca
claim to have implemented IRIs or even know enough about them to do that. I'll read up on these things in the next few days. However, this is a URI library, not IRI. From what I've seen, it's percent-encoded URIs coming in from the browser, not IRIs. We just need to make sure with this patch that IRIs don't become less-supported than they were before; don't need to explicitly support them. Cheers, Matt Giuca ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

[Python-Dev] urllib.quote and unquote - Unicode issues

2008-07-12 Thread Matt Giuca
y it). And thirdly, if the first two are positive, if anyone would like to review this patch and check it in. I have extensively tested it, and am now pretty confident that it won't cause any grief if it's checked in. Thanks very much, Matt Giuca ___