Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-31 Thread Nick Coghlan
Martin v. Löwis wrote: >> I can see how "svn resolved ." gets it right (now that I understand how >> the conflict is being produced and then fixed automatically by svnmerge, >> but not actually marked as resolved). >> >> I still don't understand how "svn revert ." can avoid losing the >> metadata c

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-30 Thread Martin v. Löwis
> I can see how "svn resolved ." gets it right (now that I understand how > the conflict is being produced and then fixed automatically by svnmerge, > but not actually marked as resolved). > > I still don't understand how "svn revert ." can avoid losing the > metadata changes unless svnmerge is to

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-30 Thread Nick Coghlan
Martin v. Löwis wrote: > See above. You claim that doing things the way I recommend will lose > metadata; I believe this claim is false. I can see how "svn resolved ." gets it right (now that I understand how the conflict is being produced and then fixed automatically by svnmerge, but not actually

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-30 Thread Martin v. Löwis
> (I believe that svnmerge actually does get that case right, but I > haven't checked it extensively - since if it does get it right, I don't > understand why it leaves the conflict in place instead of automatically > marking it as resolved). I think this is a plain bug. It invokes "svn merge", wh

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-30 Thread Martin v. Löwis
>> Ah. In the 3.0 branch, always do "svn revert ." after svnmerge. >> It's ok (Nick says it isn't exactly ok, but I don't understand why) > > Doing "svn revert ." before making the commit will lose the metadata > changes that svnmerge uses for its bookkeeping (i.e. if this practice is > used regul

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-30 Thread Nick Coghlan
Antoine Pitrou wrote: > Nick Coghlan gmail.com> writes: >> Doing "svn resolved ." assumes that you did everything else correctly, >> and even then I don't see how svnmerge could both backport the py3k >> changes to the metadata and make its own changes and still get the >> metadata to a sane state

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-30 Thread Antoine Pitrou
Nick Coghlan gmail.com> writes: > > Doing "svn resolved ." assumes that you did everything else correctly, > and even then I don't see how svnmerge could both backport the py3k > changes to the metadata and make its own changes and still get the > metadata to a sane state. The metadata are discr

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-30 Thread Nick Coghlan
Martin v. Löwis wrote: >> There are potential problems with doing it that way [1]. The safer >> option is to do: >> >> svn revert . >> svnmerge merge -M -F > > I still don't see the potential problem. If you do svnmerge, svn commit, > all is fine, right? Sort of. svnmerge still gets confused by

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-30 Thread Nick Coghlan
Martin v. Löwis wrote: >> svn up >> svnmerge >> ... conflicts >> svn revert -R . >> svn up >> svnmerge >> ... same conflicts > > Ah. In the 3.0 branch, always do "svn revert ." after svnmerge. > It's ok (Nick says it isn't exactly ok, but I don't understand why) Doing "svn revert ." before making

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-29 Thread Martin v. Löwis
> svn up > svnmerge > ... conflicts > svn revert -R . > svn up > svnmerge > ... same conflicts Ah. In the 3.0 branch, always do "svn revert ." after svnmerge. It's ok (Nick says it isn't exactly ok, but I don't understand why) Martin ___ Python-Dev mail

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-29 Thread Brett Cannon
On Thu, Jan 29, 2009 at 19:03, "Martin v. Löwis" wrote: > Brett Cannon wrote: >> On Thu, Jan 29, 2009 at 18:27, "Martin v. Löwis" wrote: There are potential problems with doing it that way [1]. The safer option is to do: svn revert . svnmerge merge -M -F >>> I still don'

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-29 Thread Martin v. Löwis
Brett Cannon wrote: > On Thu, Jan 29, 2009 at 18:27, "Martin v. Löwis" wrote: >>> There are potential problems with doing it that way [1]. The safer >>> option is to do: >>> >>> svn revert . >>> svnmerge merge -M -F >> I still don't see the potential problem. If you do svnmerge, svn commit, >> al

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-29 Thread Brett Cannon
On Thu, Jan 29, 2009 at 18:27, "Martin v. Löwis" wrote: >> There are potential problems with doing it that way [1]. The safer >> option is to do: >> >> svn revert . >> svnmerge merge -M -F > > I still don't see the potential problem. If you do svnmerge, svn commit, > all is fine, right? The probl

Re: [Python-Dev] [Python-checkins] Merging to the 3.0 maintenance branch

2009-01-29 Thread Martin v. Löwis
> There are potential problems with doing it that way [1]. The safer > option is to do: > > svn revert . > svnmerge merge -M -F I still don't see the potential problem. If you do svnmerge, svn commit, all is fine, right? The problem *only* arises if you do svnmerge, svn up, svn commit - and clea