Re: [Python-Dev] Adding support to curses library

2009-02-27 Thread Heracles
Ok, I think I have followed the process and submitted the patch via bug tracker. I also note that you have made some minor changes to the issue. The patch is ready for review and feedback. Thanks for your help. A.M. Kuchling wrote: > > On Wed, Feb 25, 2009 at 01:52:29PM -0800, st...@inte

Re: [Python-Dev] Adding support to curses library

2009-02-26 Thread A.M. Kuchling
On Wed, Feb 25, 2009 at 01:52:29PM -0800, st...@integrityintegrators.net wrote: > Are you up for helping a little more? Sure, but please open an issue on http://bugs.python.org for this; back-and-forth over a particular patch is done in the bug tracker, not the python-dev mailing list. http://www

Re: [Python-Dev] Adding support to curses library

2009-02-25 Thread Heracles
I took the suggestion and fired up a debugger and now I'm eating crow. First of all, here is a complete listing of the method as it is written now: -- Snippet --- static PyObject * PyCurses_color_set(PyObject *self, PyObject *args) { short colo

Re: [Python-Dev] Adding support to curses library

2009-02-25 Thread anatoly techtonik
Please note that there is a pending change that will introduce curses module on Windows in http://bugs.python.org/issue2889 I would really like to see the patch in the issue integrated before it became invalid due to other patches to test curses on Windows. On Wed, Feb 25, 2009 at 5:34 PM, A.M. K

Re: [Python-Dev] Adding support to curses library

2009-02-25 Thread A.M. Kuchling
On Wed, Feb 25, 2009 at 06:30:06AM -0800, Heracles wrote: > is commented back in it does fail. I am not sure exactly how a debugger will > help in this case since the color_set call goes directly to the ncurses > library. If in fact that the issue is the ncurses library then it seems > that there

Re: [Python-Dev] Adding support to curses library

2009-02-25 Thread Heracles
Thank you for your reply, and no, that is not the exact code. I must have wiped out the return statement when I copied it in. The return statement is in the code. Also the code has been modified so that the call to color_set reads as follows: erg = color_set(color_pair_number, NULL); // Debati

Re: [Python-Dev] Adding support to curses library

2009-02-25 Thread Heracles
Ulrich, Thanks for the input. That is helpful to know. H Ulrich Berning-2 wrote: > > Heracles wrote: > >>Hello, >> >>I am working on a patch to add to the _cursesmodule.c file of the Python >>core libraries. I figured I would take on one of the implemented functions >>to try to get my feet

Re: [Python-Dev] Adding support to curses library

2009-02-25 Thread Ulrich Berning
Heracles wrote: Hello, I am working on a patch to add to the _cursesmodule.c file of the Python core libraries. I figured I would take on one of the implemented functions to try to get my feet wet contributing to the project. At any rate, I have the following function defined in the 2.7.a ver

Re: [Python-Dev] Adding support to curses library

2009-02-24 Thread Neal Norwitz
On Tue, Feb 24, 2009 at 2:18 PM, Heracles wrote: > > Hello, > > I am working on a patch to add to the _cursesmodule.c file of the Python > core libraries.  I figured I would take on one of the implemented functions > to try to get my feet wet contributing to the project.  At any rate, I have > the

[Python-Dev] Adding support to curses library

2009-02-24 Thread Heracles
Hello, I am working on a patch to add to the _cursesmodule.c file of the Python core libraries. I figured I would take on one of the implemented functions to try to get my feet wet contributing to the project. At any rate, I have the following function defined in the 2.7.a version updated from