Re: [Python-Dev] Desired changes to Hg emails to python-checkins

Am 04.03.2010 21:20, schrieb Brett Cannon: > 1) I miss not having the affected files listed in the subject line. > > 2) The To field is set to h...@python.org which > gets rejected as an invalid email address if you reply. Would be better > to set it to python-checkins so

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

Am 04.03.2010 21:20, schrieb Brett Cannon: > 1) I miss not having the affected files listed in the subject line. I actually like the (first line of the) commit message better. It communicates much better what the change is about (and for me, if I want to look at/review it). However, what I miss

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

Brett Cannon writes: > I prefer the subject so that I can easily skim them to see if someone edited > a file I really care about, but if that is not possible then the body is > acceptable, especially if it is the first thing in the body (that would let > me at least see some of it in the initi

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

On Thu, Mar 4, 2010 at 13:56, Benjamin Peterson wrote: > 2010/3/4 Dirkjan Ochtman : > > On Thu, Mar 4, 2010 at 22:44, Benjamin Peterson > wrote: > >> +1 to bringing back affected files. It helps tell at a glance whether > >> a changeset is interesting or not. > > > > Do they need to be in the su

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

2010/3/4 Dirkjan Ochtman : > On Thu, Mar 4, 2010 at 22:44, Benjamin Peterson wrote: >> +1 to bringing back affected files. It helps tell at a glance whether >> a changeset is interesting or not. > > Do they need to be in the subject, or would it be fine to have them in > the message? Both is good

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

On Thu, Mar 4, 2010 at 22:44, Benjamin Peterson wrote: > +1 to bringing back affected files. It helps tell at a glance whether > a changeset is interesting or not. Do they need to be in the subject, or would it be fine to have them in the message? Cheers, Dirkjan ___

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

2010/3/4 Dirkjan Ochtman : > Well, I think it looks rather ugly, and Tarek said he'd like the first > line of the commit message in the subject instead, so that's what I've > implemented right now. But then if there's a majority who want the > files, I'm happy to put them back. +1 to bringing back

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

First off, this was just a first sample, it was by no means the definitive format. Second, the diffs are already back, in the next message (this first one was per changegroup, not per changeset -- new ones will be per changeset). On Thu, Mar 4, 2010 at 21:20, Brett Cannon wrote: > 1) I miss not

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

On Mar 04, 2010, at 03:43 PM, Eric Smith wrote: >Are the diffs gone for some deliberate reason? > >I realize the link tells me the changes, but I'll review a lot more code >if the diffs show up in my inbox than if I have to fire up a browser, >especially from my phone. Agreed, please restore th

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

Brett Cannon wrote: > 1) I miss not having the affected files listed in the subject line. > > 2) The To field is set to h...@python.org which > gets rejected as an invalid email address if you reply. Would be better > to set it to python-checkins so that the habitual reply

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

Are the diffs gone for some deliberate reason? I realize the link tells me the changes, but I'll review a lot more code if the diffs show up in my inbox than if I have to fire up a browser, especially from my phone. Eric. Brett Cannon wrote: 1) I miss not having the affected files listed in

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

Brett Cannon wrote: > 1) I miss not having the affected files listed in the subject line. > > 2) The To field is set to h...@python.org which > gets rejected as an invalid email address if you reply. Would be better > to set it to python-checkins so that the habitual reply

Re: [Python-Dev] Desired changes to Hg emails to python-checkins

On Thu, Mar 4, 2010 at 3:20 PM, Brett Cannon wrote: > 1) I miss not having the affected files listed in the subject line. > 2) The To field is set to h...@python.org which gets rejected as an invalid > email address if you reply. Would be better to set it to python-checkins so > that the habitual

[Python-Dev] Desired changes to Hg emails to python-checkins

1) I miss not having the affected files listed in the subject line. 2) The To field is set to h...@python.org which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected. At least I would lik