Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-16 Thread Larry Hastings
On 05/17/2016 02:57 AM, Brett Cannon wrote: On Mon, May 16, 2016, 19:02 Ethan Furman > wrote: Isn't 3.4 now in security-fix mode? Yes, but because of pathlib's provisional status, Guido backported the path attribute from 3.4 forward. I

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-16 Thread Brett Cannon
On Mon, May 16, 2016, 19:02 Ethan Furman wrote: > On 05/16/2016 02:32 PM, Brett Cannon wrote: > > > PEP 519 is now marked as accepted! Two PEPs accepted in one day (Nick > > approved 518 earlier)! > > Excellent! :) > > > If pathlib doesn't get updated in 3.4, 3.5, and 3.6

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-16 Thread Ethan Furman
On 05/16/2016 02:32 PM, Brett Cannon wrote: PEP 519 is now marked as accepted! Two PEPs accepted in one day (Nick approved 518 earlier)! Excellent! :) If pathlib doesn't get updated in 3.4, 3.5, and 3.6 before PyCon it will be the first thing I do at the sprints so that it isn't an issue

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-16 Thread Brett Cannon
On Mon, 16 May 2016 at 14:03 Guido van Rossum wrote: > For those following along on the list, it's PEP 519: > https://www.python.org/dev/peps/pep-0519/ > > I've read it once more and found nothing worth bickering about, so I am > hereby approving PEP 519. Thanks Brett and Koos

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-16 Thread Guido van Rossum
For those following along on the list, it's PEP 519: https://www.python.org/dev/peps/pep-0519/ I've read it once more and found nothing worth bickering about, so I am hereby approving PEP 519. Thanks Brett and Koos for getting this one over the finish line, and congrats! It's been quite an effort

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-16 Thread Brett Cannon
On Mon, 16 May 2016 at 13:12 Guido van Rossum wrote: > Once you assign yourself a PEP number I'll do one more pass and then I > expect to accept it -- the draft looks good to me! > Done: https://hg.python.org/peps/rev/b41cb718054a > > On Mon, May 16, 2016 at 1:00 PM, Brett

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-16 Thread Guido van Rossum
Once you assign yourself a PEP number I'll do one more pass and then I expect to accept it -- the draft looks good to me! On Mon, May 16, 2016 at 1:00 PM, Brett Cannon wrote: > Recent discussions have been about type hints which are orthogonal to the > PEP, so things have

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-16 Thread Brett Cannon
Recent discussions have been about type hints which are orthogonal to the PEP, so things have seemed to have reached a steady state. Was there anything else that needed clarification, Guido, or are you ready to pronounce? Or did you want to wait until the language summit? Or did you want to

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-13 Thread Koos Zevenhoven
FYI, I recently sent a couple of emails in my earlier type hinting thread on -ideas. What I wrote now is about the path ABC regarding type hints. -- Koos On Sat, May 14, 2016 at 12:48 AM, Brett Cannon wrote: > > > On Fri, 13 May 2016 at 14:30 Philip Jenvey

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-13 Thread Brett Cannon
On Fri, 13 May 2016 at 14:30 Philip Jenvey wrote: > > On May 13, 2016, at 11:37 AM, Brett Cannon wrote: > > Biggest changes since the second draft: > >1. Resolve __fspath__() from the type, not the instance (for Guido) > > > if

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-13 Thread Philip Jenvey
> On May 13, 2016, at 11:37 AM, Brett Cannon wrote: > > Biggest changes since the second draft: > Resolve __fspath__() from the type, not the instance (for Guido) > if (PyObject_HasAttrString(path->ob_type, "__fspath__")) { > return

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-13 Thread Guido van Rossum
Can't wait until the peps repo is on GitHub! On Fri, May 13, 2016 at 12:24 PM, Brett Cannon wrote: > > > On Fri, 13 May 2016 at 12:08 Barry Warsaw wrote: > >> On May 13, 2016, at 06:37 PM, Brett Cannon wrote: >> >> >PEP: NNN >> >Title: Adding a file system

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-13 Thread Brett Cannon
On Fri, 13 May 2016 at 12:08 Barry Warsaw wrote: > On May 13, 2016, at 06:37 PM, Brett Cannon wrote: > > >PEP: NNN > >Title: Adding a file system path protocol > >Version: $Revision$ > >Last-Modified: $Date$ > >Author: Brett Cannon , > >Koos Zevenhoven

Re: [Python-Dev] File system path PEP, 3rd draft

2016-05-13 Thread Barry Warsaw
On May 13, 2016, at 06:37 PM, Brett Cannon wrote: >PEP: NNN >Title: Adding a file system path protocol >Version: $Revision$ >Last-Modified: $Date$ >Author: Brett Cannon , >Koos Zevenhoven >Status: Draft >Type: Standards Track >Content-Type: text/x-rst

[Python-Dev] File system path PEP, 3rd draft

2016-05-13 Thread Brett Cannon
Biggest changes since the second draft: 1. Resolve __fspath__() from the type, not the instance (for Guido) 2. Updated the TypeError messages to say "os.PathLike object" instead of "path object" (implicitly for Steven) 3. TODO item to define "path-like" in the glossary (for Steven)