Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-10 Thread Michael Foord
Brett Cannon wrote: OK, since no one has really said anything, I am going to assume no one has issues with importlib in terms of me checking it in or choosing a name for it (I like importlib more than imp so I will probably stick with that). So I will do some file renaming and reorganization, ge

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-09 Thread Brett Cannon
OK, since no one has really said anything, I am going to assume no one has issues with importlib in terms of me checking it in or choosing a name for it (I like importlib more than imp so I will probably stick with that). So I will do some file renaming and reorganization, get the code set up to b

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Paul Moore
2009/1/8 Nick Coghlan : >> Well, it's not part of the interpreter yet. That can be viewed as a >> separate step. > > True, but what you're doing here can be viewed as the continuation of > the original implementation plan for PEP 302 - it was always intended > that every module would eventually get

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 13:21, Nick Coghlan wrote: > Brett Cannon wrote: >> On Thu, Jan 8, 2009 at 12:35, Nick Coghlan wrote: >>> Brett Cannon wrote: One, does anyone have issues if I check in importlib? We have typically said code has to have been selected as best-of-breed by the c

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 13:14, Antoine Pitrou wrote: > Brett Cannon python.org> writes: >> >> One, does anyone have issues if I check in importlib? We have >> typically said code has to have been selected as best-of-breed by the >> community first, so I realize I am asking for a waiver on this one

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Nick Coghlan
Brett Cannon wrote: > On Thu, Jan 8, 2009 at 12:35, Nick Coghlan wrote: >> Brett Cannon wrote: >>> One, does anyone have issues if I check in importlib? We have >>> typically said code has to have been selected as best-of-breed by the >>> community first, so I realize I am asking for a waiver on t

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Antoine Pitrou
Brett Cannon python.org> writes: > > One, does anyone have issues if I check in importlib? We have > typically said code has to have been selected as best-of-breed by the > community first, so I realize I am asking for a waiver on this one. Have you tried to assess its interaction with setuptool

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Jesse Noller
On Thu, Jan 8, 2009 at 3:57 PM, Paul Moore wrote: > 2009/1/8 Brett Cannon : >> Thanks, Paul! I changed it to _os.getcwd() since that's what nt exposes. > > Ta. I wasn't sure _os.getcwd() returned a full pathname. > > The only difference between the importlib results and the normal ones > seems to

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 12:57, Paul Moore wrote: > 2009/1/8 Brett Cannon : >> Thanks, Paul! I changed it to _os.getcwd() since that's what nt exposes. > > Ta. I wasn't sure _os.getcwd() returned a full pathname. > > The only difference between the importlib results and the normal ones > seems to be

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 12:35, Nick Coghlan wrote: > Brett Cannon wrote: >> One, does anyone have issues if I check in importlib? We have >> typically said code has to have been selected as best-of-breed by the >> community first, so I realize I am asking for a waiver on this one. > > That rule has

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Paul Moore
2009/1/8 Brett Cannon : > Thanks, Paul! I changed it to _os.getcwd() since that's what nt exposes. Ta. I wasn't sure _os.getcwd() returned a full pathname. The only difference between the importlib results and the normal ones seems to be that with importlib, test_multiprocessing is skipped, where

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Nick Coghlan
Brett Cannon wrote: > One, does anyone have issues if I check in importlib? We have > typically said code has to have been selected as best-of-breed by the > community first, so I realize I am asking for a waiver on this one. That rule has never really applied to things that are part of the interp

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 11:26, Paul Moore wrote: > 2009/1/8 Brett Cannon : >> My work rewriting import in pure Python code has reached beta. >> Basically the code is semantically complete and as >> backwards-compatible as I can make it short of widespread testing or >> running on a Windows box. > >

Re: [Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Paul Moore
2009/1/8 Brett Cannon : > My work rewriting import in pure Python code has reached beta. > Basically the code is semantically complete and as > backwards-compatible as I can make it short of widespread testing or > running on a Windows box. I should have done this earlier, sorry. A quick test on W

[Python-Dev] Getting importlib into the standard library for 3.1

2009-01-08 Thread Brett Cannon
My work rewriting import in pure Python code has reached beta. Basically the code is semantically complete and as backwards-compatible as I can make it short of widespread testing or running on a Windows box. There are still some tweaks here and there I want to make and an API to expose, but __impo