Re: [Python-Dev] Procedure for adding new public C API

2018-05-22 Thread Paul Moore
On 22 May 2018 at 18:00, Steve Dower wrote: > On 21May2018 0708, Paul Moore wrote: >> >> On 21 May 2018 at 14:42, Serhiy Storchaka wrote: Is it even acceptable to add a symbol into the limited ABI? I thought the idea was that if I

Re: [Python-Dev] Procedure for adding new public C API

2018-05-22 Thread Steve Dower
On 21May2018 0708, Paul Moore wrote: On 21 May 2018 at 14:42, Serhiy Storchaka wrote: Is it even acceptable to add a symbol into the limited ABI? I thought the idea was that if I linked with python3.dll, my code would work with any version of Python 3? By introducing new

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Masayuki YAMAMOTO
Thanks Serhiy, I missed adding PyThread_tss_* to Doc/data/refcounts.dat. I opened a PR to fix it. https://github.com/python/cpython/pull/7038 Regards, Masayuki 2018-05-21 21:41 GMT+09:00 Serhiy Storchaka : > Please don't forgot to perform the following steps when add a new

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Paul Moore
On 21 May 2018 at 14:42, Serhiy Storchaka wrote: >> Is it even acceptable to add a symbol into the limited ABI? I thought >> the idea was that if I linked with python3.dll, my code would work >> with any version of Python 3? By introducing new symbols, code linked >> with the

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Serhiy Storchaka
21.05.18 16:27, Paul Moore пише: On 21 May 2018 at 13:41, Serhiy Storchaka wrote: * Add it in PC/python3.def. I thought python3.def should only contain symbols in the limited ABI (it defines the API of python3.dll, doesn't it?) Thank you for correction. Yes, and only

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Paul Moore
On 21 May 2018 at 13:41, Serhiy Storchaka wrote: > Please don't forgot to perform the following steps when add a new public C > API: > > * Document it in Doc/c-api/. > > * Add an entry in the What's New document. > > * Add it in Doc/data/refcounts.dat. > > * Add it in

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Ned Deily
On May 21, 2018, at 08:41, Serhiy Storchaka wrote: > Please don't forgot to perform the following steps when add a new public C > API: > [...] Perhaps this should be added to the Python Developer's Guide? -- Ned Deily n...@python.org -- []

[Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Serhiy Storchaka
Please don't forgot to perform the following steps when add a new public C API: * Document it in Doc/c-api/. * Add an entry in the What's New document. * Add it in Doc/data/refcounts.dat. * Add it in PC/python3.def. If you want to include it in the limited API, wrap its declaration with: