Thomas Heller wrote:
> #if (PY_VERSION_HEX < 0x02050000)
> typedef int Py_ssize_t;
> #define lenfunc inquiry
> #define readbufferproc getreadbufferproc
> #define writebufferproc getwritebufferproc
> #define segcountproc getsegcountproc
> #define charbufferproc getcharbufferproc
> #define ssizeargfunc intargfunc
> #define ssizessizeargfunc intintargfunc
> #define ssizeobjargproc intobjargproc
> #define ssizessizeobjargproc intintobjargproc
> ... more defines
> #endif
Thinking about this, I now believe (again) that this isn't
what people should do. Instead, they should avoid these
type names altogether, and should avoid casting function
pointers.
The reason they currently do that is because of the self
pointer: the self pointer should have the specific type,
instead of being PyObject*, so that you can access the fields
of the object.
The reason they should avoid this is that this casting is
error-prone: If they make a mistake in the signature
(e.g. forget to replace int with Py_ssize_t), the compiler
will not tell them. This happened to me a few times while
converting modules to Py_ssize_t; you need to be very
careful when using these casts.
OTOH, the solution to avoid them is pretty mechanic, and
straight-forward. Just drop the casts, and replace
Py_ssize_t foo_len(Foo* self)
{
...
}
with
Py_ssize_t foo_len(PyObject* _self)
{
Foo* self = (Foo*)_self;
...
}
Then, foo_len will already have the type lenfunc, and
no cast is required. If you have also
#if (PY_VERSION_HEX < 0x02050000)
typedef int Py_ssize_t;
#endif
then this code will work unmodified in earlier versions:
foo_len will be of type int (*)(PyObject*), which is
precisely the type inquiry that it should have in the
earlier versions.
See
http://sourceforge.net/tracker/index.php?func=detail&aid=1453037&group_id=71702&atid=532156
for an example of applying this approach to ctypes.
Regards,
Martin
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
