[Python-Dev] Re: Constructing expected_opinfo_* lists in test_dis.py

2021-02-02 Thread Skip Montanaro
> The problem is not that dis.get_instructions can't be trusted, but that > the test isn't testing the dis module at all. It is testing whether the > output from the compiler has changed. > A lot of the tests in test_dis do that. Thanks. Perhaps such tests belong in a different test_* module? (I a

[Python-Dev] Re: Constructing expected_opinfo_* lists in test_dis.py

2021-02-01 Thread Mark Shannon
Hi Skip, On 01/02/2021 9:50 pm, Skip Montanaro wrote: Guido> Maybe these lines in test_dis.py? ... Skip> Thanks, I'll take a look. I was expecting there'd be a standalone Skip> script somewhere. Hadn't considered that comments would be hiding Skip> code. Indeed, that did the trick, however... I

[Python-Dev] Re: Constructing expected_opinfo_* lists in test_dis.py

2021-02-01 Thread Skip Montanaro
Guido> Maybe these lines in test_dis.py? ... Skip> Thanks, I'll take a look. I was expecting there'd be a standalone Skip> script somewhere. Hadn't considered that comments would be hiding Skip> code. Indeed, that did the trick, however... I'm a bit uncomfortable with the methodology. It seems tes

[Python-Dev] Re: Constructing expected_opinfo_* lists in test_dis.py

2021-02-01 Thread Skip Montanaro
> Maybe these lines in test_dis.py? > ``` > #print('expected_opinfo_jumpy = [\n ', > #',\n '.join(map(str, _instructions)), ',\n]', sep='') > ``` Thanks, I'll take a look. I was expecting there'd be a standalone script somewhere. Hadn't considered that comments would be hiding code. Skip

[Python-Dev] Re: Constructing expected_opinfo_* lists in test_dis.py

2021-01-31 Thread Guido van Rossum
Maybe these lines in test_dis.py? ``` #print('expected_opinfo_jumpy = [\n ', #',\n '.join(map(str, _instructions)), ',\n]', sep='') ``` On Sun, Jan 31, 2021 at 6:07 PM Skip Montanaro wrote: > I'm still messing around with my register VM stuff (off-and-on). I'm > trying to adjust to some