Re: [Python-Dev] Refactor __get_builtin_constructor on hasklib.py

2018-08-08 Thread Tsai Park
Dear Sanyam,Mariatta and Steve, Thanks for your feedback. I will read https://devguide.python.org/ carefully. Best regards, Park Tsai 2018-08-08 2:04 GMT+08:00 Steve Holden : > Hi there, > > Good to see you on python-dev. It's always good to see people getting > excited about helping with Python'

Re: [Python-Dev] Refactor __get_builtin_constructor on hasklib.py

2018-08-07 Thread Steve Holden
Hi there, Good to see you on python-dev. It's always good to see people getting excited about helping with Python's development. The changes you suggest are, unless I've missed something, purely cosmetic - affecting readability only. This implies that you feel the code as it stands isn't as reada

Re: [Python-Dev] Refactor __get_builtin_constructor on hasklib.py

2018-08-07 Thread Mariatta Wijaya
2.7 is for bug fixes only. Unless there is a bug to be fixed, I would leave the code as is. Mariatta On Tue, Aug 7, 2018 at 8:14 AM 蔡銘峯 wrote: > Hello everybody, > I am Park Tsai. I want to refactor __get_builtin_constructor on hasklib.py > of python 2.7 ( > https://github.com/python/cpython/b

Re: [Python-Dev] Refactor __get_builtin_constructor on hasklib.py

2018-08-07 Thread Sanyam Khurana
Hello, Welcome to the mailing list Park! On Tue, Aug 7, 2018 at 12:30 PM, 蔡銘峯 wrote: > Hello everybody, > I am Park Tsai. I want to refactor __get_builtin_constructor on hasklib.py > of python 2.7 > (https://github.com/python/cpython/blob/2.7/Lib/hashlib.py#L72). > This is the first time that I

[Python-Dev] Refactor __get_builtin_constructor on hasklib.py

2018-08-07 Thread 蔡銘峯
Hello everybody, I am Park Tsai. I want to refactor __get_builtin_constructor on hasklib.py of python 2.7 (https://github.com/python/cpython/blob/2.7/Lib/hashlib.py#L72). This is the first time that I try to refactor code of CPython on GitHub, so I am very excited. This is __get_builtin_construct