Re: [Python-Dev] Regexp 2.7

2009-03-10 Thread Antoine Pitrou
Hello, > So, if there's interest in investigating how much of the PCRE tests > can augment the existing tests, I am offering to do so. IMO there's nothing wrong with having more tests, provided that: - they don't make the test suite slower than it should be - they aren't too implementation-spec

Re: [Python-Dev] Regexp 2.7

2009-03-10 Thread Nick Coghlan
Terry Reedy wrote: > There is a conflict between running a thorough test of everything > possible and not having the test suite run for hours. I believe a > couple of other modules have a regular sanity-check test and an extended > patch-check test. Something like that might be appropriate for re

Re: [Python-Dev] Regexp 2.7

2009-03-10 Thread Terry Reedy
Jared Grubb wrote: I'm not criticizing the current battery of tests, nor am I arguing that we replace them. There's a comment in the test_re.py that says that "these tests were carefully modeled to cover most of the code"... That is a very difficult statement to maintain and/or verify, especi

Re: [Python-Dev] Regexp 2.7

2009-03-10 Thread Jared Grubb
I'm not criticizing the current battery of tests, nor am I arguing that we replace them. There's a comment in the test_re.py that says that "these tests were carefully modeled to cover most of the code"... That is a very difficult statement to maintain and/or verify, especially if the lib

Re: [Python-Dev] Regexp 2.7

2009-03-10 Thread A.M. Kuchling
On Tue, Mar 10, 2009 at 11:32:10AM -0700, Guido van Rossum wrote: > Hm, what's wrong with the existing set of regex test cases? This is > one of the most complete set of test cases in our test suite. There's never anything wrong with having more test cases! However, if you have a choice of which

Re: [Python-Dev] Regexp 2.7

2009-03-10 Thread Guido van Rossum
Hm, what's wrong with the existing set of regex test cases? This is one of the most complete set of test cases in our test suite. On Tue, Mar 10, 2009 at 11:08 AM, Jared Grubb wrote: > Would there be any interest in augmenting the test case library for the > regex stuff? > > When I was working on

Re: [Python-Dev] Regexp 2.7

2009-03-10 Thread Jared Grubb
Would there be any interest in augmenting the test case library for the regex stuff? When I was working on PyPy, we were using a simplified regular expression matcher to implement the tokenizer for Python. I was able to take a lot of PCRE's regex tests and port them to test our regular ex

Re: [Python-Dev] Regexp 2.7

2009-03-09 Thread Antoine Pitrou
Facundo Batista gmail.com> writes: > > > Matthew Barnett has been doing a lot of work on the regular expressions engine > > (it seems he hasn't finished yet) under http://bugs.python.org/issue2636. > > However, the patches are really huge and touch all of the sre internals. I > > wonder what the

Re: [Python-Dev] Regexp 2.7

2009-03-09 Thread Facundo Batista
2009/3/7 Antoine Pitrou : > Matthew Barnett has been doing a lot of work on the regular expressions engine > (it seems he hasn't finished yet) under http://bugs.python.org/issue2636. > However, the patches are really huge and touch all of the sre internals. I > wonder what the review process can b

Re: [Python-Dev] Regexp 2.7

2009-03-07 Thread Martin v. Löwis
> Matthew Barnett has been doing a lot of work on the regular expressions engine > (it seems he hasn't finished yet) under http://bugs.python.org/issue2636. > However, the patches are really huge and touch all of the sre internals. I > wonder what the review process can be for such patches? Is ther

[Python-Dev] Regexp 2.7

2009-03-07 Thread Antoine Pitrou
Hello, Matthew Barnett has been doing a lot of work on the regular expressions engine (it seems he hasn't finished yet) under http://bugs.python.org/issue2636. However, the patches are really huge and touch all of the sre internals. I wonder what the review process can be for such patches? Is ther