Re: [Python-Dev] Stop automerging

2018-09-12 Thread Victor Stinner
Oh yes, one issue of missing bpo-xxx is that bots don't report merged commits into the bpo. I like using the bpo issue to track backports: https://bugs.python.org/issue31902 It was just a general remark, it's fine for these commits. Someone can add them manually to the bpo if you want. Victor Le

Re: [Python-Dev] Stop automerging

2018-09-12 Thread Victor Stinner
Hi Benjamin, https://github.com/python/cpython/commit/d13e59c1b512069d90efe7ee9b613d3913e79c56 Le mer. 12 sept. 2018 à 17:19, Benjamin Peterson a écrit : > (Just checking) Is there something wrong with this message besides the <-- > comment? Since the commit is described as a follow-up of 90fc

Re: [Python-Dev] Stop automerging

2018-09-12 Thread Benjamin Peterson
On Wed, Sep 12, 2018, at 01:33, Serhiy Storchaka wrote: > 12.09.18 01:34, Miss Islington (bot) пише: > > https://github.com/python/cpython/commit/d13e59c1b512069d90efe7ee9b613d3913e79c56 > > commit: d13e59c1b512069d90efe7ee9b613d3913e79c56 > > branch: master > > author: Benjamin Peterson > > com

Re: [Python-Dev] Stop automerging

2018-09-12 Thread Mariatta Wijaya
Thanks Zach for fixing it quickly. Even if that bug has been fixed, per my instructions to python-committers, core devs should still edit the PR title and PR description *before* adding the '🤖 automerge' label. The YouTube video (link in python-committers email) shows to edit those. The PR titl

Re: [Python-Dev] Stop automerging

2018-09-12 Thread Zachary Ware
It is still up to the core dev to set the message properly, but the HTML comments are invisible on GitHub until you edit the message. That bug is now fixed, though; HTML comments are stripped from the message before creating the commit. -- Zach (Top-posted in HTML from a phone) On Wed, Sep 12, 20

[Python-Dev] Stop automerging

2018-09-12 Thread Serhiy Storchaka
12.09.18 01:34, Miss Islington (bot) пише: https://github.com/python/cpython/commit/d13e59c1b512069d90efe7ee9b613d3913e79c56 commit: d13e59c1b512069d90efe7ee9b613d3913e79c56 branch: master author: Benjamin Peterson committer: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.co