Re: [Python-Dev] Tests for internal functionality

2019-03-30 Thread Nick Coghlan
On Sun, 17 Mar 2019 at 07:27, Terry Reedy wrote: > > On 3/16/2019 3:10 AM, Ivan Pozdeev via Python-Dev wrote: > > In https://github.com/python/cpython/pull/6541 , I was requested to add > > tests for an internal C function. > > > > As I wrote in > > https://github.com/python/cpython/pull/6541#issu

Re: [Python-Dev] Tests for internal functionality

2019-03-16 Thread Terry Reedy
On 3/16/2019 3:10 AM, Ivan Pozdeev via Python-Dev wrote: In https://github.com/python/cpython/pull/6541 , I was requested to add tests for an internal C function. As I wrote in https://github.com/python/cpython/pull/6541#issuecomment-445514807 , it's not clear from the codebase 1) where tes

[Python-Dev] Tests for internal functionality

2019-03-16 Thread Ivan Pozdeev via Python-Dev
In https://github.com/python/cpython/pull/6541 , I was requested to add tests for an internal C function. As I wrote in https://github.com/python/cpython/pull/6541#issuecomment-445514807 , it's not clear from the codebase 1) where tests for internal (as opposed to public) functionality should