Re: [Python-Dev] adding threaded tests to the test suite

2017-01-22 Thread Serhiy Storchaka
On 22.01.17 22:02, Ethan Furman wrote: Question: I need to add a threaded test to the enum test module [1] -- is there anything extra I need to worry about besides the test itself? Setting or resetting or using a tool library, etc? You can use the test.support.start_threads() context

Re: [Python-Dev] adding threaded tests to the test suite

2017-01-22 Thread Ethan Furman
On 01/22/2017 12:02 PM, Ethan Furman wrote: Question: I need to add a threaded test to the enum test module [1] -- is there anything extra I need to worry about besides the test itself? Setting or resetting or using a tool library, etc? Thanks everyone. @support.reap_threads and skipping

Re: [Python-Dev] adding threaded tests to the test suite

2017-01-22 Thread Zachary Ware
On Sun, Jan 22, 2017 at 2:39 PM, Martin Panter wrote: > As I understand, @reap_threads basically does a join() on each > background thread, with a total timeout of 1 s. So since your test is > unlikely to fail between starting threads and joining them, I don’t > think you

Re: [Python-Dev] adding threaded tests to the test suite

2017-01-22 Thread Zachary Ware
On Sun, Jan 22, 2017 at 2:02 PM, Ethan Furman wrote: > Question: I need to add a threaded test to the enum test module [1] -- is > there anything extra I > need to worry about besides the test itself? Setting or resetting or using > a tool library, etc? As far as I know,

Re: [Python-Dev] adding threaded tests to the test suite

2017-01-22 Thread Martin Panter
> Le dim. 22 janv. 2017 à 21:04, Ethan Furman a écrit : >> Question: I need to add a threaded test to the enum test module [1] -- is >> there anything extra I >> need to worry about besides the test itself? Setting or resetting or >> using a tool library, etc? >> >> threads

Re: [Python-Dev] adding threaded tests to the test suite

2017-01-22 Thread Victor Stinner
There is @support.reap_thread which can help. Victor Le dim. 22 janv. 2017 à 21:04, Ethan Furman a écrit : > Question: I need to add a threaded test to the enum test module [1] -- is > there anything extra I > > need to worry about besides the test itself? Setting or

[Python-Dev] adding threaded tests to the test suite

2017-01-22 Thread Ethan Furman
Question: I need to add a threaded test to the enum test module [1] -- is there anything extra I need to worry about besides the test itself? Setting or resetting or using a tool library, etc? -- ~Ethan~ [1] The test to be added: def test_unique_composite(self): # override