Re: [Python-Dev] asyncore patch

2008-06-10 Thread Nick Coghlan
Josiah Carlson wrote: On Mon, Jun 9, 2008 at 7:19 PM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Mon, Jun 9, 2008 at 8:42 PM, Josiah Carlson [EMAIL PROTECTED] wrote: Would it be ok if I committed the changes? Neal, do you want to commit the changes if I post an updated patch with a blurb

Re: [Python-Dev] asyncore patch

2008-06-10 Thread Barry Warsaw
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Jun 10, 2008, at 9:08 AM, Georg Brandl wrote: Nick Coghlan schrieb: Josiah Carlson wrote: On Mon, Jun 9, 2008 at 7:19 PM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Mon, Jun 9, 2008 at 8:42 PM, Josiah Carlson [EMAIL PROTECTED] wrote:

Re: [Python-Dev] asyncore patch

2008-06-10 Thread Georg Brandl
Nick Coghlan schrieb: Josiah Carlson wrote: On Mon, Jun 9, 2008 at 7:19 PM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Mon, Jun 9, 2008 at 8:42 PM, Josiah Carlson [EMAIL PROTECTED] wrote: Would it be ok if I committed the changes? Neal, do you want to commit the changes if I post an

Re: [Python-Dev] asyncore patch

2008-06-10 Thread Benjamin Peterson
On Tue, Jun 10, 2008 at 8:10 AM, Barry Warsaw [EMAIL PROTECTED] wrote: I don't want to be picky, but it seems the commit broke the tests: test test_asyncore failed -- Traceback (most recent call last): File /tmp/python-test/local/lib/python2.6/test/test_asyncore.py, line 387, in test_recv

Re: [Python-Dev] asyncore patch

2008-06-10 Thread Josiah Carlson
I'm working on it now. I'll do my best to have a fix by the time I go to work this morning. - Josiah On Tue, Jun 10, 2008 at 6:12 AM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Tue, Jun 10, 2008 at 8:10 AM, Barry Warsaw [EMAIL PROTECTED] wrote: I don't want to be picky, but it seems the

Re: [Python-Dev] asyncore patch

2008-06-10 Thread Giampaolo Rodola'
On 10 Giu, 07:01, Josiah Carlson [EMAIL PROTECTED] wrote: On Mon, Jun 9, 2008 at 7:19 PM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Mon, Jun 9, 2008 at 8:42 PM, Josiah Carlson [EMAIL PROTECTED] wrote: Would it be ok if I committed the changes?  Neal, do you want to commit the changes

Re: [Python-Dev] asyncore patch

2008-06-10 Thread Josiah Carlson
On Tue, Jun 10, 2008 at 8:26 AM, Giampaolo Rodola' [EMAIL PROTECTED] wrote: On 10 Giu, 07:01, Josiah Carlson [EMAIL PROTECTED] wrote: On Mon, Jun 9, 2008 at 7:19 PM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Mon, Jun 9, 2008 at 8:42 PM, Josiah Carlson [EMAIL PROTECTED] wrote: Would it

[Python-Dev] asyncore patch

2008-06-09 Thread Josiah Carlson
As we approach the 2.6 beta date, and after getting my updated public key pushed to the python.org servers, I would really like to get the asyncore/asynchat patch (with documentation) committed. Previously, we were waiting on documentation, which the last patch had, but which was 80 columns.

Re: [Python-Dev] asyncore patch

2008-06-09 Thread Benjamin Peterson
On Mon, Jun 9, 2008 at 8:42 PM, Josiah Carlson [EMAIL PROTECTED] wrote: Would it be ok if I committed the changes? Neal, do you want to commit the changes if I post an updated patch with a blurb for the NEWS file? You are the asyncore maintainer, correct? I believe it's pretty much up to

Re: [Python-Dev] asyncore patch

2008-06-09 Thread Josiah Carlson
On Mon, Jun 9, 2008 at 7:19 PM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Mon, Jun 9, 2008 at 8:42 PM, Josiah Carlson [EMAIL PROTECTED] wrote: Would it be ok if I committed the changes? Neal, do you want to commit the changes if I post an updated patch with a blurb for the NEWS file?