Re: [Python-Dev] cpython: Issue #1172711: Add 'long long' support to the array module.

2011-09-21 Thread Ezio Melotti
On 21/09/2011 21.08, Michael Foord wrote: On 21/09/2011 18:02, Stephen J. Turnbull wrote: Georg Brandl writes: > I don't think so. "skip if not" reads pretty well for me, while I > always have to think twice about "unless" -- may be a non-native- > speaker thing. FWIW, speaking as one nativ

Re: [Python-Dev] cpython: Issue #1172711: Add 'long long' support to the array module.

2011-09-21 Thread Michael Foord
On 21/09/2011 18:02, Stephen J. Turnbull wrote: Georg Brandl writes: > I don't think so. "skip if not" reads pretty well for me, while I > always have to think twice about "unless" -- may be a non-native- > speaker thing. FWIW, speaking as one native speaker, I'm not sure about that.

Re: [Python-Dev] cpython: Issue #1172711: Add 'long long' support to the array module.

2011-09-21 Thread Stephen J. Turnbull
Georg Brandl writes: > I don't think so. "skip if not" reads pretty well for me, while I > always have to think twice about "unless" -- may be a non-native- > speaker thing. FWIW, speaking as one native speaker, I'm not sure about that. "do ... if not condition" doesn't bother me, whether I t

Re: [Python-Dev] cpython: Issue #1172711: Add 'long long' support to the array module.

2011-09-21 Thread Benjamin Peterson
2011/9/21 Georg Brandl : > Am 21.09.2011 15:25, schrieb Ezio Melotti: > >>> @@ -1205,6 +1214,18 @@ >>>       minitemsize = 4 >>>   tests.append(UnsignedLongTest) >>> >>> +@unittest.skipIf(not have_long_long, 'need long long support') >> >> I think this would read better with skipUnless and s/have/h

Re: [Python-Dev] cpython: Issue #1172711: Add 'long long' support to the array module.

2011-09-21 Thread Georg Brandl
Am 21.09.2011 15:25, schrieb Ezio Melotti: >> @@ -1205,6 +1214,18 @@ >> minitemsize = 4 >> tests.append(UnsignedLongTest) >> >> +@unittest.skipIf(not have_long_long, 'need long long support') > > I think this would read better with skipUnless and s/have/has/: > > @unittest.skipUnless(HAS