Re: [Python-Dev] generated NEWS files

2008-04-12 Thread Martin v. Löwis
#!/bin/sh REPOS=$1 REV=$2 USER=$3 PROPNAME=$4 /data/repos/projects/hooks/mailer.py propchange $@ The script is the same mailer.py that is also invoked in post-commit. Can anybody see a problem with that? No, but how many parameters are passed to mailer.py? if cmd ==

Re: [Python-Dev] generated NEWS files

2008-04-11 Thread Martin v. Löwis
While it's easy to fix NEWS its not easy to fix changelog entries (only a few svn super-users can do it, and it's a pain). Actually, any committer can do that: svn pe --revprop -rrev svn:log It may be difficult to remember, but it's fairly easy to execute. Regards, Martin

Re: [Python-Dev] generated NEWS files

2008-04-11 Thread Christian Heimes
Benjamin Peterson schrieb: I know that doing merges is rather painful because of the Misc/NEWS files. Would it be possible to have the NEWS log generated from commit messages? I was thinking something like this in a message: No, it's not painful ;) The NEWS files doesn't get merged from trunk

Re: [Python-Dev] generated NEWS files

2008-04-11 Thread Benjamin Peterson
On Fri, Apr 11, 2008 at 2:23 AM, Martin v. Löwis [EMAIL PROTECTED] wrote: While it's easy to fix NEWS its not easy to fix changelog entries (only a few svn super-users can do it, and it's a pain). Actually, any committer can do that: svn pe --revprop -rrev svn:log Wow, I'm adding

Re: [Python-Dev] generated NEWS files

2008-04-11 Thread Martin v. Löwis
I just tried it, and although it works, I get this output: svn: 'post-revprop-change' hook failed; no error output available Significant? It's the mailer.py hook failing. I'm not quite sure why it fails, and had no time to look it up. It reads #!/bin/sh REPOS=$1 REV=$2 USER=$3 PROPNAME=$4

Re: [Python-Dev] generated NEWS files

2008-04-11 Thread Brett Cannon
On Fri, Apr 11, 2008 at 2:28 PM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Fri, Apr 11, 2008 at 2:23 AM, Martin v. Löwis [EMAIL PROTECTED] wrote: While it's easy to fix NEWS its not easy to fix changelog entries (only a few svn super-users can do it, and it's a pain).

Re: [Python-Dev] generated NEWS files

2008-04-11 Thread Neal Norwitz
On Fri, Apr 11, 2008 at 2:53 PM, Martin v. Löwis [EMAIL PROTECTED] wrote: I just tried it, and although it works, I get this output: svn: 'post-revprop-change' hook failed; no error output available Significant? It's the mailer.py hook failing. I'm not quite sure why it fails, and

[Python-Dev] generated NEWS files

2008-04-10 Thread Benjamin Peterson
I know that doing merges is rather painful because of the Misc/NEWS files. Would it be possible to have the NEWS log generated from commit messages? I was thinking something like this in a message: Fixed this and that **NEWS:Library** #1234 X is now known as Y. It should be fairly simple to

Re: [Python-Dev] generated NEWS files

2008-04-10 Thread Guido van Rossum
In the past we haven't done that because often the change logs are either too chatty (they do administrative stuff that doesn't deserve a NEWS entry) or they are too brief (in the heat of the battle developers don't always write great changelog entries). While it's easy to fix NEWS its not easy to

Re: [Python-Dev] generated NEWS files

2008-04-10 Thread Benjamin Peterson
On Thu, Apr 10, 2008 at 7:55 PM, Guido van Rossum [EMAIL PROTECTED] wrote: In the past we haven't done that because often the change logs are either too chatty (they do administrative stuff that doesn't deserve a NEWS entry) or they are too brief (in the heat of the battle developers don't

Re: [Python-Dev] generated NEWS files

2008-04-10 Thread Guido van Rossum
On Thu, Apr 10, 2008 at 5:59 PM, Benjamin Peterson [EMAIL PROTECTED] wrote: On Thu, Apr 10, 2008 at 7:55 PM, Guido van Rossum [EMAIL PROTECTED] wrote: In the past we haven't done that because often the change logs are either too chatty (they do administrative stuff that doesn't deserve a

Re: [Python-Dev] generated NEWS files

2008-04-10 Thread Gregory P. Smith
On Thu, Apr 10, 2008 at 6:24 PM, Guido van Rossum [EMAIL PROTECTED] wrote: Also, there's the issue of which section of the NEWS file an entry should be added. That's often subjective. Agreed. For example we have both Library and Extension Module categories in the NEWS file. I always end up