Re: [Python-Dev] pymigr: Ask for hgeol-checking hook.

2011-02-26 Thread Antoine Pitrou
On Sat, 26 Feb 2011 18:48:17 +0100 martin.v.loewis python-check...@python.org wrote: * some hook should prevent pushing python files indented by tabs. * some hook should prevent pushing to the 2.x trunk. +* some hook should prevent breaking EOL conventions. We don't have such hook in SVN,

Re: [Python-Dev] pymigr: Ask for hgeol-checking hook.

2011-02-26 Thread Martin v. Löwis
Am 26.02.2011 18:54, schrieb Antoine Pitrou: On Sat, 26 Feb 2011 18:48:17 +0100 martin.v.loewis python-check...@python.org wrote: * some hook should prevent pushing python files indented by tabs. * some hook should prevent pushing to the 2.x trunk. +* some hook should prevent breaking EOL

Re: [Python-Dev] pymigr: Ask for hgeol-checking hook.

2011-02-26 Thread Antoine Pitrou
In Mercurial, it's just a hook, and optional. So we can't be sure all users use it correctly - and in my (limited) experience with Mercurial, chances are high that users will make mistakes in that respect (i.e. in one out of one cross-platform projects, a committer had issues with CRLF,

Re: [Python-Dev] pymigr: Ask for hgeol-checking hook.

2011-02-26 Thread Martin v. Löwis
Am 26.02.2011 19:13, schrieb Antoine Pitrou: In Mercurial, it's just a hook, and optional. So we can't be sure all users use it correctly - and in my (limited) experience with Mercurial, chances are high that users will make mistakes in that respect (i.e. in one out of one cross-platform

Re: [Python-Dev] pymigr: Ask for hgeol-checking hook.

2011-02-26 Thread Antoine Pitrou
Martin, I have now enabled the eol hook on the test repo (a quick test seemed to show it works). Could you test again? Regards Antoine. On Sat, 26 Feb 2011 19:23:49 +0100 Martin v. Löwis mar...@v.loewis.de wrote: Am 26.02.2011 19:13, schrieb Antoine Pitrou: In Mercurial, it's just a

Re: [Python-Dev] pymigr: Ask for hgeol-checking hook.

2011-02-26 Thread Tim Delaney
On 27 February 2011 05:23, Martin v. Löwis mar...@v.loewis.de wrote: It actually happened to me, so please trust me that it's not a legend. Yes, I could fix it with hg commands, and a lot of text editing. It took me a day, I considered the repository corrupted so that I actually had to branch

Re: [Python-Dev] pymigr: Ask for hgeol-checking hook.

2011-02-26 Thread Neil Hodgson
Line end problems do occur in real projects. A scintilla-cocoa project was branched off Scintilla to support the Cocoa GUI framework on OS X. Here is one of the revisions in that project: http://bazaar.launchpad.net/~mike-lischke/scintilla-cocoa/trunk/revision/5#include/ScintillaWidget.h If

Re: [Python-Dev] pymigr: Ask for hgeol-checking hook.

2011-02-26 Thread Martin v. Löwis
Am 26.02.2011 20:30, schrieb Antoine Pitrou: Martin, I have now enabled the eol hook on the test repo (a quick test seemed to show it works). Could you test again? It seems to work fine, thanks. I modified a file with Visual Studio, and that changed all line endings. I then decided to fix it