Re: [Python-Dev] r88758 - tracker/instances/python-dev/scripts/addpatchsets

2011-03-06 Thread Terry Reedy
On 3/6/2011 11:43 AM, Antoine Pitrou wrote: compute the base rev. Most reviewable patches should apply cleanly against the latest revision on "default", That was sensible when we ported patches back, but if they should be ported forward (3.1 => 3.2 => default), do we not want the patch to ap

Re: [Python-Dev] r88758 - tracker/instances/python-dev/scripts/addpatchsets

2011-03-06 Thread Martin v. Löwis
Would you like to contribute a patch to make that work? It's too tedious to work without a base revision, so for the time being, this cannot be supported. Well, no. I was assuming that basing all patches on tip would make things simpler. It's very easy to get the base code if you know the base

Re: [Python-Dev] r88758 - tracker/instances/python-dev/scripts/addpatchsets

2011-03-06 Thread Antoine Pitrou
On Sun, 06 Mar 2011 18:23:58 +0100 "Martin v. Löwis" wrote: > >> -def find_bases(data, rev): > >> +def hg_splitpatch(data): > >> +patches = [] > >> +filename = None > >> +for line in data.splitlines(True): > >> +if line.startswith('diff -r'): > > > > Now I understand why you wo

Re: [Python-Dev] r88758 - tracker/instances/python-dev/scripts/addpatchsets

2011-03-06 Thread Martin v. Löwis
-def find_bases(data, rev): +def hg_splitpatch(data): +patches = [] +filename = None +for line in data.splitlines(True): +if line.startswith('diff -r'): Now I understand why you would like to discourage git diffs. But, as I said back then, I don't think it's worthwhile to try

Re: [Python-Dev] r88758 - tracker/instances/python-dev/scripts/addpatchsets

2011-03-06 Thread Antoine Pitrou
On Sun, 6 Mar 2011 17:32:40 +0100 (CET) martin.v.loewis wrote: > > -def find_bases(data, rev): > +def hg_splitpatch(data): > +patches = [] > +filename = None > +for line in data.splitlines(True): > +if line.startswith('diff -r'): Now I understand why you would like to disco