Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread Eric Snow
Good catch. Unfortunately, sticking keys = ((PyDictObject *)od)-ma_keys; right after hash = ... did not make a difference. I still get the same segfault. -eric On Thu, May 21, 2015 at 11:17 AM, MRAB pyt...@mrabarnett.plus.com wrote: On 2015-05-21 15:55, Eric Snow wrote: (see

[Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread Eric Snow
(see http://bugs.python.org/issue16991) I an working on resolving an intermittent segfault that my C OrderedDict patch introduces. The failure happens in test_configparser (RawConfigParser uses OrderedDict internally), but only sporadically. However, Ned pointed out to me that it appears to be

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread Eric Snow
On Thu, May 21, 2015 at 4:06 PM, MRAB pyt...@mrabarnett.plus.com wrote: On 2015-05-21 22:52, Eric Snow wrote: Good catch. Unfortunately, sticking keys = ((PyDictObject *)od)-ma_keys; right after hash = ... did not make a difference. I still get the same segfault. So, does it change

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread MRAB
On 2015-05-22 00:22, Eric Snow wrote: On Thu, May 21, 2015 at 4:41 PM, MRAB pyt...@mrabarnett.plus.com wrote: On 2015-05-21 23:17, Eric Snow wrote: The segfault is consistent if I use the same seed (e.g. 7): PYTHONHASHSEED=7 ./python -m test.regrtest -m test_basic test_configparser

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread MRAB
On 2015-05-21 22:52, Eric Snow wrote: Good catch. Unfortunately, sticking keys = ((PyDictObject *)od)-ma_keys; right after hash = ... did not make a difference. I still get the same segfault. So, does it change sometimes? On Thu, May 21, 2015 at 11:17 AM, MRAB pyt...@mrabarnett.plus.com

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread MRAB
On 2015-05-21 23:17, Eric Snow wrote: On Thu, May 21, 2015 at 4:06 PM, MRAB pyt...@mrabarnett.plus.com wrote: On 2015-05-21 22:52, Eric Snow wrote: Good catch. Unfortunately, sticking keys = ((PyDictObject *)od)-ma_keys; right after hash = ... did not make a difference. I still get the

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread Eric Snow
On Thu, May 21, 2015 at 4:41 PM, MRAB pyt...@mrabarnett.plus.com wrote: On 2015-05-21 23:17, Eric Snow wrote: The segfault is consistent if I use the same seed (e.g. 7): PYTHONHASHSEED=7 ./python -m test.regrtest -m test_basic test_configparser Some seeds always segfault and some seeds

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread MRAB
On 2015-05-22 01:12, Eric Snow wrote: On Thu, May 21, 2015 at 5:55 PM, MRAB pyt...@mrabarnett.plus.com wrote: I'm not looking at the use of PyTuple_Pack. As I understand it, PyTuple_Pack borrows the references of the objects passed, and when the tuple itself is DECREFed, those objects will

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread Eric Snow
On Thu, May 21, 2015 at 6:22 PM, MRAB pyt...@mrabarnett.plus.com wrote: Oh, well, I'll keep looking... I've posted some data to http://bugs.python.org/issue16991 that I hope will shed some light on the issue. We can continue the conversation there. -eric

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread Eric Snow
On Thu, May 21, 2015 at 5:55 PM, MRAB pyt...@mrabarnett.plus.com wrote: I'm not looking at the use of PyTuple_Pack. As I understand it, PyTuple_Pack borrows the references of the objects passed, and when the tuple itself is DECREFed, those objects will be DECREFed From the docs [1] it seems

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread Eric Snow
On Thu, May 21, 2015 at 6:22 PM, MRAB pyt...@mrabarnett.plus.com wrote: Oh, well, I'll keep looking... Thanks! -eric ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] segfaults due to hash randomization in C OrderedDict

2015-05-21 Thread MRAB
On 2015-05-21 15:55, Eric Snow wrote: (see http://bugs.python.org/issue16991) I an working on resolving an intermittent segfault that my C OrderedDict patch introduces. The failure happens in test_configparser (RawConfigParser uses OrderedDict internally), but only sporadically. However, Ned