Re: [Python-Dev] [Python-checkins] r84559 - python/branches/py3k/Lib/subprocess.py

2010-09-07 Thread Nick Coghlan
On Tue, Sep 7, 2010 at 2:29 AM, brian.curtin python-check...@python.org wrote: Author: brian.curtin Date: Mon Sep  6 18:29:29 2010 New Revision: 84559 Log: Fix #8956. ValueError message was only mentioning one signal. Rather than list out the three signals (or more over time), the message

Re: [Python-Dev] [Python-checkins] r84559 - python/branches/py3k/Lib/subprocess.py

2010-09-07 Thread Brian Curtin
On Tue, Sep 7, 2010 at 07:34, Nick Coghlan ncogh...@gmail.com wrote: On Tue, Sep 7, 2010 at 2:29 AM, brian.curtin python-check...@python.org wrote: Author: brian.curtin Date: Mon Sep 6 18:29:29 2010 New Revision: 84559 Log: Fix #8956. ValueError message was only mentioning one

Re: [Python-Dev] [Python-checkins] r84559 - python/branches/py3k/Lib/subprocess.py

2010-09-07 Thread Nick Coghlan
On Tue, Sep 7, 2010 at 11:05 PM, Brian Curtin brian.cur...@gmail.com wrote: Sure, seems reasonable to me. Does raise ValueError(Unsupported signal: {}.format(sig)) look fine, or is there a more preferred format when displaying bad values in exception messages? No, that's about what I was

Re: [Python-Dev] [Python-checkins] r84559 - python/branches/py3k/Lib/subprocess.py

2010-09-07 Thread Brian Curtin
On Tue, Sep 7, 2010 at 08:19, Nick Coghlan ncogh...@gmail.com wrote: On Tue, Sep 7, 2010 at 11:05 PM, Brian Curtin brian.cur...@gmail.com wrote: Sure, seems reasonable to me. Does raise ValueError(Unsupported signal: {}.format(sig)) look fine, or is there a more preferred format when