Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Masayuki YAMAMOTO
Thanks Serhiy, I missed adding PyThread_tss_* to Doc/data/refcounts.dat. I opened a PR to fix it. https://github.com/python/cpython/pull/7038 Regards, Masayuki 2018-05-21 21:41 GMT+09:00 Serhiy Storchaka : > Please don't forgot to perform the following steps when add a new

Re: [Python-Dev] My fork lacks a 3.7 branch - can I create it somehow?

2018-05-21 Thread Chris Angelico
On Tue, May 22, 2018 at 10:45 AM, Skip Montanaro wrote: >> Create it from upstream? Yep! Try this: > >> git checkout -b 3.7 upstream/3.7 >> git push -u origin 3.7 > > Thanks, Chris! Didn't have to chug for too long either, just a few seconds. > > S Perfect! I'm used to

Re: [Python-Dev] My fork lacks a 3.7 branch - can I create it somehow?

2018-05-21 Thread Skip Montanaro
> Create it from upstream? Yep! Try this: > git checkout -b 3.7 upstream/3.7 > git push -u origin 3.7 Thanks, Chris! Didn't have to chug for too long either, just a few seconds. S ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] My fork lacks a 3.7 branch - can I create it somehow?

2018-05-21 Thread Chris Angelico
On Tue, May 22, 2018 at 10:07 AM, Skip Montanaro wrote: > My GitHub fork of the cpython repo was made awhile ago, before a 3.7 branch > was created. I have no remotes/origin/3.7. Is there some way to create it > from remotes/upstream/3.7? I asked on GitHub's help forums.

Re: [Python-Dev] "make test" routinely fails to terminate

2018-05-21 Thread Skip Montanaro
me> On the 3.7 branch, "make test" routinely fails to terminate. Antoine> Can you try to rebuild Python? Use "make distclean" if that helps. Thanks, Antoine. That solved the termination problem. I still have problems with test_asyncio failing, but I can live with that for now. If "make

[Python-Dev] My fork lacks a 3.7 branch - can I create it somehow?

2018-05-21 Thread Skip Montanaro
My GitHub fork of the cpython repo was made awhile ago, before a 3.7 branch was created. I have no remotes/origin/3.7. Is there some way to create it from remotes/upstream/3.7? I asked on GitHub's help forums. The only recommendation was to to delete my fork and recreate it. That seemed kind of

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Paul Moore
On 21 May 2018 at 14:42, Serhiy Storchaka wrote: >> Is it even acceptable to add a symbol into the limited ABI? I thought >> the idea was that if I linked with python3.dll, my code would work >> with any version of Python 3? By introducing new symbols, code linked >> with the

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Serhiy Storchaka
21.05.18 16:27, Paul Moore пише: On 21 May 2018 at 13:41, Serhiy Storchaka wrote: * Add it in PC/python3.def. I thought python3.def should only contain symbols in the limited ABI (it defines the API of python3.dll, doesn't it?) Thank you for correction. Yes, and only

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Paul Moore
On 21 May 2018 at 13:41, Serhiy Storchaka wrote: > Please don't forgot to perform the following steps when add a new public C > API: > > * Document it in Doc/c-api/. > > * Add an entry in the What's New document. > > * Add it in Doc/data/refcounts.dat. > > * Add it in

Re: [Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Ned Deily
On May 21, 2018, at 08:41, Serhiy Storchaka wrote: > Please don't forgot to perform the following steps when add a new public C > API: > [...] Perhaps this should be added to the Python Developer's Guide? -- Ned Deily n...@python.org -- []

[Python-Dev] Procedure for adding new public C API

2018-05-21 Thread Serhiy Storchaka
Please don't forgot to perform the following steps when add a new public C API: * Document it in Doc/c-api/. * Add an entry in the What's New document. * Add it in Doc/data/refcounts.dat. * Add it in PC/python3.def. If you want to include it in the limited API, wrap its declaration with: