[Python-Dev] Re: Map errno==ETIME to TimeoutError

2020-05-25 Thread Giampaolo Rodola' 
Sure. Done.

On Mon, 25 May 2020 at 21:05, Eric V. Smith  wrote:

> Thanks, Giampaolo. Could you leave a comment on the issue?
>
> Erci
> On 5/25/2020 10:32 AM, Giampaolo Rodola' wrote:
>
> I'm -1 because the concept of "timeout" is generic enough to be often
> implemented as a custom exception, which poses questions re.
> backward/forward compatibilty. E.g. in psutil I have "TimeoutExpired", also
> providing a "seconds" attribute. Also I've probably never seen ETIME /
> ETIMEDOUT happening, whereas AFAIU the point PEP 3151 was to create
> mappings for the most common errnos.
>
> On Sun, May 24, 2020 at 6:48 PM Eric V. Smith  wrote:
>
>> Does anyone have an opinion on https://bugs.python.org/issue39673? It
>> maps ETIME to TimeoutError, in addition to the already existing ETIMEDOUT.
>>
>> http://man7.org/linux/man-pages/man3/errno.3.html says:
>>
>>*ETIME   *Timer expired (POSIX.1 (XSI STREAMS option)).
>>
>>(POSIX.1 says "STREAM ioctl(2) 
>>  timeout".)
>>
>>*ETIMEDOUT   *Connection timed out (POSIX.1-2001).
>>
>>
>> It seems like a reasonable change to me, but I'm not a subject matter
>> expert on STREAMS, or what other affect this might have.
>>
>> And if added to 3.10, should it be backported? I'd tend to say "no",
>> because of unknown impacts on existing code.
>>
>> Eric
>> ___
>> Python-Dev mailing list -- python-dev@python.org
>> To unsubscribe send an email to python-dev-le...@python.org
>> https://mail.python.org/mailman3/lists/python-dev.python.org/
>> Message archived at
>> https://mail.python.org/archives/list/python-dev@python.org/message/C7KK6VSGPQKPA5IUCZ2MHH7QNLP2Q5QX/
>> Code of Conduct: http://python.org/psf/codeofconduct/
>>
>
>
> --
> Giampaolo - http://grodola.blogspot.com
>
> --
Giampaolo - http://grodola.blogspot.com
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/DJXIGSGZ2G7OJYPWZWH265FDP3PP3U6B/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: Map errno==ETIME to TimeoutError

2020-05-25 Thread Eric V. Smith 

Thanks, Giampaolo. Could you leave a comment on the issue?

Erci

On 5/25/2020 10:32 AM, Giampaolo Rodola' wrote:
I'm -1 because the concept of "timeout" is generic enough to be often 
implemented as a custom exception, which poses questions re. 
backward/forward compatibilty. E.g. in psutil I have "TimeoutExpired", 
also providing a "seconds" attribute. Also I've probably never seen 
ETIME / ETIMEDOUT happening, whereas AFAIU the point PEP 3151 was to 
create mappings for the most common errnos.


On Sun, May 24, 2020 at 6:48 PM Eric V. Smith > wrote:


Does anyone have an opinion on https://bugs.python.org/issue39673?
It maps ETIME to TimeoutError, in addition to the already existing
ETIMEDOUT.

http://man7.org/linux/man-pages/man3/errno.3.html says:

*ETIME *Timer expired (POSIX.1 (XSI STREAMS option)).

(POSIX.1 says "STREAMioctl(2)  
  timeout".)

*ETIMEDOUT *Connection timed out (POSIX.1-2001).
  


It seems like a reasonable change to me, but I'm not a subject
matter expert on STREAMS, or what other affect this might have.

And if added to 3.10, should it be backported? I'd tend to say
"no", because of unknown impacts on existing code.

Eric

___
Python-Dev mailing list -- python-dev@python.org

To unsubscribe send an email to python-dev-le...@python.org

https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at

https://mail.python.org/archives/list/python-dev@python.org/message/C7KK6VSGPQKPA5IUCZ2MHH7QNLP2Q5QX/
Code of Conduct: http://python.org/psf/codeofconduct/



--
Giampaolo - http://grodola.blogspot.com

___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/J6NYK7THGZ3D4HCBX6ICSNSWIASGKHFN/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: Map errno==ETIME to TimeoutError

2020-05-25 Thread Giampaolo Rodola' 
I'm -1 because the concept of "timeout" is generic enough to be often
implemented as a custom exception, which poses questions re.
backward/forward compatibilty. E.g. in psutil I have "TimeoutExpired", also
providing a "seconds" attribute. Also I've probably never seen ETIME /
ETIMEDOUT happening, whereas AFAIU the point PEP 3151 was to create
mappings for the most common errnos.

On Sun, May 24, 2020 at 6:48 PM Eric V. Smith  wrote:

> Does anyone have an opinion on https://bugs.python.org/issue39673? It
> maps ETIME to TimeoutError, in addition to the already existing ETIMEDOUT.
>
> http://man7.org/linux/man-pages/man3/errno.3.html says:
>
>*ETIME   *Timer expired (POSIX.1 (XSI STREAMS option)).
>
>(POSIX.1 says "STREAM ioctl(2) 
>  timeout".)
>
>*ETIMEDOUT   *Connection timed out (POSIX.1-2001).
>
>
> It seems like a reasonable change to me, but I'm not a subject matter
> expert on STREAMS, or what other affect this might have.
>
> And if added to 3.10, should it be backported? I'd tend to say "no",
> because of unknown impacts on existing code.
>
> Eric
>
> ___
> Python-Dev mailing list -- python-dev@python.org
> To unsubscribe send an email to python-dev-le...@python.org
> https://mail.python.org/mailman3/lists/python-dev.python.org/
> Message archived at
> https://mail.python.org/archives/list/python-dev@python.org/message/C7KK6VSGPQKPA5IUCZ2MHH7QNLP2Q5QX/
> Code of Conduct: http://python.org/psf/codeofconduct/
>


-- 
Giampaolo - http://grodola.blogspot.com
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/B4Y2UZ3Z7ARHVP5JTP27UV2OH2PSDZ4P/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: Map errno==ETIME to TimeoutError

2020-05-25 Thread Eric V. Smith 


On 5/25/2020 4:25 AM, Serhiy Storchaka wrote:

24.05.20 17:48, Eric V. Smith пише:
Does anyone have an opinion on https://bugs.python.org/issue39673? It 
maps ETIME to TimeoutError, in addition to the already existing 
ETIMEDOUT.


http://man7.org/linux/man-pages/man3/errno.3.html says:

    *ETIME *Timer expired (POSIX.1 (XSI STREAMS option)).

    (POSIX.1 says "STREAMioctl(2) 
 timeout".)


    *ETIMEDOUT *Connection timed out (POSIX.1-2001).

It seems like a reasonable change to me, but I'm not a subject matter 
expert on STREAMS, or what other affect this might have.


Why it was not mapped at first place? Was there any discussion?


Good question. Perhaps Antoine can answer.

I don't see any mention of ETIME in PEP 3151. I'm assuming it was just 
an oversight. I couldn't find any reference to ETIME on python-ideas or 
python-dev (other than this discussion), either.


Eric

___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/WK5LQE7CBEMF2C4FPFOCCQQBZQISH72Y/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: Map errno==ETIME to TimeoutError

2020-05-25 Thread Nathaniel Smith 
On Mon, May 25, 2020 at 1:25 AM Serhiy Storchaka  wrote:
>
> 24.05.20 17:48, Eric V. Smith пише:
> > Does anyone have an opinion on https://bugs.python.org/issue39673? It
> > maps ETIME to TimeoutError, in addition to the already existing ETIMEDOUT.
> >
> > http://man7.org/linux/man-pages/man3/errno.3.html says:
> >
> > *ETIME *Timer expired (POSIX.1 (XSI STREAMS option)).
> >
> > (POSIX.1 says "STREAMioctl(2)  
> >   timeout".)
> >
> > *ETIMEDOUT *Connection timed out (POSIX.1-2001).
> >
> >
> > It seems like a reasonable change to me, but I'm not a subject matter
> > expert on STREAMS, or what other affect this might have.
>
> Why it was not mapped at first place? Was there any discussion?

AFAICT from a few minutes of searching, ETIME is almost never used,
which probably explains it. It doesn't show up in glibc at all, and
only a few times in the Linux kernel sources, most notably in the
graphics subsystem -- and apparently this causes some annoyance for
the *BSDs, which share a bunch of that code and don't have ETIME, so
they #define ETIME ETIMEDOUT to get the code to build.

I'm not sure there's any point in making the change – the BPO doesn't
even have an example of it, just someone who was poking around in
obscure corners of errno and noticed it – but it seems harmless. It
sounds like literally no-one knows what the difference between these
is supposed to be.

-n

-- 
Nathaniel J. Smith -- https://vorpus.org
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/PTDLD2ZTMIEYRQTWVK6ECSC2YDIVNHVJ/
Code of Conduct: http://python.org/psf/codeofconduct/

[Python-Dev] Re: Map errno==ETIME to TimeoutError

2020-05-25 Thread Serhiy Storchaka 

24.05.20 17:48, Eric V. Smith пише:
Does anyone have an opinion on https://bugs.python.org/issue39673? It 
maps ETIME to TimeoutError, in addition to the already existing ETIMEDOUT.


http://man7.org/linux/man-pages/man3/errno.3.html says:

*ETIME *Timer expired (POSIX.1 (XSI STREAMS option)).

(POSIX.1 says "STREAMioctl(2)  
  timeout".)

*ETIMEDOUT *Connection timed out (POSIX.1-2001).
  

It seems like a reasonable change to me, but I'm not a subject matter 
expert on STREAMS, or what other affect this might have.


Why it was not mapped at first place? Was there any discussion?
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/ZZOPRIAPXMX3G32XAU6BW6Y4QB26OOGD/
Code of Conduct: http://python.org/psf/codeofconduct/