Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Bill Janssen
This occurs on at least 3 of the buildbots (ubuntu and debian on ia64, ppc, and hppa). Here's one example: Unfortunately, I don't have Ubuntu or Debian machines. But I'd bet it's a variation in the specific version of OpenSSL being used. I just tested on Fedora Core 7, though, and test_ssl

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Bill Janssen
This occurs on at least 3 of the buildbots (ubuntu and debian on ia64, ppc, and hppa). Here's one example: http://python.org/dev/buildbot/all/ia64%20Ubuntu%20trunk%20trunk/builds/832/step-test/0 If I'm reading this right, it's passing tests on amd64 gentoo trunk, x86 gentoo trunk, g4 osx.4

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Neal Norwitz
On 8/26/07, Bill Janssen [EMAIL PROTECTED] wrote: This occurs on at least 3 of the buildbots (ubuntu and debian on ia64, ppc, and hppa). Here's one example: http://python.org/dev/buildbot/all/ia64%20Ubuntu%20trunk%20trunk/builds/832/step-test/0 If I'm reading this right, it's passing

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Bill Janssen
But I think this exposes a more generic bug in test_ssl.py, which is that the server thread doesn't die when one of these failures occurs. It probably should. I'll make a patch -- but I don't have a system that this fails on, how will I test it? Here's a patch which makes test_ssl a better

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Guido van Rossum
No need, I've submitted this for you. Fingers crossed. On 8/26/07, Bill Janssen [EMAIL PROTECTED] wrote: But I think this exposes a more generic bug in test_ssl.py, which is that the server thread doesn't die when one of these failures occurs. It probably should. I'll make a patch -- but I

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Bill Janssen
Yeah, I know this is difficult. Hopefully someone with WIndows will step up to help. We can at least make the test more robust and verify the files exist and are non-zero in size. I will do that now. At least the it shouldn't cause the test to time out. Yes, the patch I sent out should

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Bill Janssen
Well, as long as you have your ears on, here's another patch to test_ssl. 1) Fixes the bug that two class names are initial-lower-case. 2) Replaces the poll waiting for the server to become ready with a threading.Event signal. Bill Index: Lib/test/test_ssl.py

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Neal Norwitz
Thanks. I applied it. -- n On 8/26/07, Bill Janssen [EMAIL PROTECTED] wrote: Well, as long as you have your ears on, here's another patch to test_ssl. 1) Fixes the bug that two class names are initial-lower-case. 2) Replaces the poll waiting for the server to become ready with a

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Bill Janssen
Traceback (most recent call last): File /home/pybot/buildarea/trunk.klose-debian-ia64/build/Lib/threading.py, line 486, in __bootstrap_inner self.run() File /home/pybot/buildarea/trunk.klose-debian-ia64/build/Lib/test/test_ssl.py, line 144, in run

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Bill Janssen
Now it looks as if both the Debian and Ubuntu failures are failing because they can't create a certificate, just like the Windows test. I'll go out on a limb here and guess that it's because openssl isn't on the path of the user running the tests. That would also account for the other stack

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Bill Janssen
Here's a patch that will turn the buildbots green, by not trying the connected tests if the certificate can't be created. It also shows the created cert if run in verbose mode. We still need a working os.system command for Windows. Bill Index: Lib/test/test_ssl.py

Re: [Python-Dev] Other SSL issues in the tracker have been marked

2007-08-26 Thread Gregory P. Smith
apt-get install openssl will fix that on those systems. on windows you're unlikely to ever have an openssl binary present and available to execute. On 8/26/07, Bill Janssen [EMAIL PROTECTED] wrote: Now it looks as if both the Debian and Ubuntu failures are failing because they can't create a