Re: [Python-Dev] devguide: Issue #18871: make it more explicit that the test suite should be run before

2013-08-28 Thread Antoine Pitrou
On Wed, 28 Aug 2013 20:05:25 -0400 Terry Reedy wrote: > On 8/28/2013 5:51 PM, antoine.pitrou wrote: > > > +Does the test suite still pass? > > There are several assumptions packed in that question. > > 0. The test suite is relevant to the patch. > > Not true for doc patches, some idlelib patch

Re: [Python-Dev] Add a new tracemalloc module to trace memory allocations

2013-08-28 Thread Victor Stinner
2013/8/29 Victor Stinner : > My proposed implementation for Python 3.4 is different: > > * no enable() / disable() function: tracemalloc can only be enabled > before startup by setting PYTHONTRACEMALLOC=1 environment variable > > * traces (size of the memory block, Python filename, Python line > nu

[Python-Dev] Add a new tracemalloc module to trace memory allocations

2013-08-28 Thread Victor Stinner
Hi, Thanks to the PEP 445, it becomes possible to trace easily memory allocations. I propose to add a new tracemalloc module computing the memory usage per file and per line number. It has also a private method to retrieve the location (filename and line number) of a memory allocation of an object

Re: [Python-Dev] Test the test suite?

2013-08-28 Thread Nick Coghlan
On 29 Aug 2013 02:34, "Serhiy Storchaka" wrote: > > 28.08.13 14:37, Victor Stinner написав(ла): > >> No, my question is: how can we detect that a test is never run? Do we >> need test covertage on the test suite? Or inject faults in the code to >> test the test suite? Any other idea? > > > Current

Re: [Python-Dev] cpython: Issue #18571: Implementation of the PEP 446: file descriptors and file handles

2013-08-28 Thread Victor Stinner
2013/8/28 Antoine Pitrou : > Well, reviewing a 1500-line commit is not very doable. You can use Rietveld if you prefer: http://bugs.python.org/review/18571/#ps9085 The commit is this patch + changes to Misc/NEWS and Doc/whatnews/3.4.rst. Victor ___ Pyt

Re: [Python-Dev] cpython: Issue #18571: Implementation of the PEP 446: file descriptors and file handles

2013-08-28 Thread Antoine Pitrou
On Wed, 28 Aug 2013 21:43:00 +0200 Victor Stinner wrote: > 2013/8/28 Antoine Pitrou : > > I don't want to sound too demanding, but was this patch actually > > reviewed? I can't find a single review comment in > > http://bugs.python.org/issue18571 > > No, it was not. The first patch for the PEP 44

Re: [Python-Dev] cpython: Issue #18571: Implementation of the PEP 446: file descriptors and file handles

2013-08-28 Thread Victor Stinner
2013/8/28 Antoine Pitrou : > I don't want to sound too demanding, but was this patch actually > reviewed? I can't find a single review comment in > http://bugs.python.org/issue18571 No, it was not. The first patch for the PEP 446 (issue #18571) was available for a review approximatively one month

Re: [Python-Dev] cpython: Issue #18571: Implementation of the PEP 446: file descriptors and file handles

2013-08-28 Thread Antoine Pitrou
Hi, On Wed, 28 Aug 2013 01:20:56 +0200 (CEST) victor.stinner wrote: > http://hg.python.org/cpython/rev/ef889c3d5dc6 > changeset: 85420:ef889c3d5dc6 > user:Victor Stinner > date:Wed Aug 28 00:53:59 2013 +0200 > summary: > Issue #18571: Implementation of the PEP 446: file desc

Re: [Python-Dev] Test the test suite?

2013-08-28 Thread Serhiy Storchaka
28.08.13 14:37, Victor Stinner написав(ла): No, my question is: how can we detect that a test is never run? Do we need test covertage on the test suite? Or inject faults in the code to test the test suite? Any other idea? Currently a lot of tests are skipped silently. See issue18702 [1]. Perha

Re: [Python-Dev] Accepted: PEP 446 -- Make newly created file descriptors non-inheritable

2013-08-28 Thread MRAB
On 28/08/2013 07:29, Paul Moore wrote: On 27 August 2013 23:17, Guido van Rossum mailto:gu...@python.org>> wrote: Thanks for your tiresome work I'm guessing you meant "tireless" here :-) That depends. It might have been tiresome for the one doing it! _

Re: [Python-Dev] Test the test suite?

2013-08-28 Thread Xavier de Gaye
It happens that few tests are also never run because of name conflicts. See issue 16056. Xavier On Wed, Aug 28, 2013 at 1:37 PM, Victor Stinner wrote: > Hi, > > I just noticed that tests using @requires_freebsd_version and > @requires_linux_version decorator from test.support are never run > sin

Re: [Python-Dev] Accepted: PEP 446 -- Make newly created file descriptors non-inheritable

2013-08-28 Thread Guido van Rossum
Whoop. Yes. I guess it was me who was tired. :-) On Tuesday, August 27, 2013, Paul Moore wrote: > On 27 August 2013 23:17, Guido van Rossum 'cvml', 'gu...@python.org');> > > wrote: > >> Thanks for your tiresome work > > > I'm guessing you meant "tireless" here :-) > > Paul > -- --Guido van Ro

[Python-Dev] Test the test suite?

2013-08-28 Thread Victor Stinner
Hi, I just noticed that tests using @requires_freebsd_version and @requires_linux_version decorator from test.support are never run since this commit (almost 2 years ago): changeset: 72618:3b1859f80e6d user:Charles-François Natali date:Mon Oct 03 19:40:37 2011 +0200 files: